Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct installation requires --server-side=true #139

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

aledegano
Copy link
Contributor

@aledegano aledegano commented Nov 21, 2024

The command:

kubectl apply -f https://github.com/shipwright-io/build/releases/latest/download/release.yaml

Will fail with the error:
The CustomResourceDefinition "buildruns.shipwright.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

This commit updates

Similar to shipwright-io/build#1315.

Changes

Update the the documentation to include the flag --server-side=true when installing Shipwright build directly from the manifest.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

The command:

```bash
kubectl apply -f https://github.com/shipwright-io/build/releases/latest/download/release.yaml
```
Will fail with the error:
`The CustomResourceDefinition "buildruns.shipwright.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes`

This commit updates the documentation to include the flag.

Similar to shipwright-io/build#1315.

Signed-off-by: Alessandro Degano <[email protected]>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2024
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thank you @aledegano

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone Nov 21, 2024
@SaschaSchwarze0 SaschaSchwarze0 added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0038e73 into shipwright-io:main Nov 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants