Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncs content/en with shipwright.io/build/docs #113

Merged
merged 1 commit into from
May 14, 2024
Merged

Syncs content/en with shipwright.io/build/docs #113

merged 1 commit into from
May 14, 2024

Conversation

apoorvajagtap
Copy link
Member

Changes

Syncs the content/en/docs/* content per shipwright.io/build/docs

Fixes #74

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 27, 2024
@apoorvajagtap
Copy link
Member Author

apoorvajagtap commented Mar 27, 2024 •
edited
Loading

/kind doc

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

@apoorvajagtap: The label(s) kind/doc cannot be applied, because the repository doesn't have them.

In response to this:

/kind doc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apoorvajagtap
Copy link
Member Author

/kind documentation

@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 27, 2024
@adambkaplan adambkaplan added this to the release-v0.13.0 milestone Apr 1, 2024
@adambkaplan adambkaplan mentioned this pull request Apr 1, 2024
Closed
adambkaplan
adambkaplan reviewed May 13, 2024
View reviewed changes
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

One item on a link that is referenced in the docs (a change that should be fixed in the build directory).- Otherwise lgtm

content/en/docs/build/configuration.md
Comment on lines -14 to +12
The controller is installed into Kubernetes with reasonable defaults. However, there are some settings that can be overridden using environment variables in [`controller.yaml`](https://github.com/shipwright-io/build/blob/v0.10.0/deploy/500-controller.yaml).
The controller is installed into Kubernetes with reasonable defaults. However, there are some settings that can be overridden using environment variables in [`controller.yaml`](../deploy/500-controller.yaml).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to reference the main branch - otherwise we end up with a broken link.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
adambkaplan
adambkaplan approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Willing to live with the broken link - we can fix the broken link at a later date.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6f273f1 into shipwright-io:main May 14, 2024
6 checks passed
@apoorvajagtap apoorvajagtap mentioned this pull request May 24, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@rolfedh rolfedh Awaiting requested review from rolfedh

@SaschaSchwarze0 SaschaSchwarze0 Awaiting requested review from SaschaSchwarze0

Assignees

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Shipwright Overview
Archived in project
Milestone
release-v0.13.0
Development

Successfully merging this pull request may close these issues.

Update existing docs and enhance the automation sync
2 participants
@apoorvajagtap @adambkaplan