Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Triggers Controller #1

Closed

Conversation

adambkaplan
Copy link
Member

@adambkaplan adambkaplan commented May 26, 2022

Initialize with KubeBuilder

  • Set up project with kubebuilder init.
  • Add Gikngo v2 and gomega for e2e testing
  • Vendor go code

Build, Deploy, and Test with ko

  • Update Makefile to use go install instead of go get
  • Use script to install kustomize (go install not supported)
  • Update manifests to use ko-enabled image references
  • Add make target to install ko, update Makefile to build and deploy
    with ko.
  • Fix namings
    • Use label shipwright.io/component, value "triggers" to group the
      deployment and services together.
    • Use shipwright-triggers as prefix
    • Rename deployment to "controller"
  • Add end to end test to ensure the deployment works correctly.
  • Add documentation on how to build, deploy, and test Triggers in a local
    development environment.
  • Add pull request template.
  • Add GitHub action to lint release notes, draft a release, and run CI
    tests.

/kind feature

Initialize Triggers project with main function and Makefile targets to build, push, and test the controller. Also set up scaffolding for end to end testing.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 26, 2022
@openshift-ci openshift-ci bot requested review from SaschaSchwarze0 and sbose78 May 26, 2022 01:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
@adambkaplan
Copy link
Member Author

@otaviof apparently this needs to merge first before we get GitHub actions? 🤷

- Set up project with `kubebuilder init`.
- Add Gikngo v2 and gomega for e2e testing
- Vendor go code
- Update Makefile to use `go install` instead of `go get`
- Use script to install kustomize (go install not supported)
- Update manifests to use ko-enabled image references
- Add make target to install ko, update Makefile to build and deploy
  with ko.
- Fix namings
  - Use label shipwright.io/component, value "triggers" to group the
    deployment and services together.
  - Use shipwright-triggers as prefix
  - Rename deployment to "controller"
- Add end to end test to ensure the deployment works correctly.
- Add documentation on how to build, deploy, and test Triggers in a local
  development environment.
- Add pull request template.
- Add GitHub action to lint release notes, draft a release, and run CI
  tests.
@adambkaplan adambkaplan force-pushed the bootstrap-controllers branch from 483ed0a to 3b0091c Compare May 27, 2022 19:09
@openshift-ci openshift-ci bot added release-note and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 27, 2022
@adambkaplan adambkaplan added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 27, 2022
@adambkaplan adambkaplan changed the title WIP - Bootstrap controllers Initialize Triggers Controller May 27, 2022
@adambkaplan
Copy link
Member Author

alright @otaviof this is now ready for review. This gives us a "hello world" Kubebuilder controller manager, so to speak. I will have a follow-up PR that ports what I have in shipwright-io/build#1063 here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2022

@adambkaplan: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2022
@otaviof
Copy link
Member

otaviof commented Jun 15, 2022

alright @otaviof this is now ready for review. This gives us a "hello world" Kubebuilder controller manager, so to speak. I will have a follow-up PR that ports what I have in shipwright-io/build#1063 here.

Great to hear, Adam! Thank you. I'm going through your PR today, let me know if I can help with the rebase work.

@adambkaplan
Copy link
Member Author

/close

Will be replaced by #4

@openshift-ci openshift-ci bot closed this Nov 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

@adambkaplan: Closed this PR.

In response to this:

/close

Will be replaced by #4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot pushed a commit that referenced this pull request May 1, 2023
Dropping Support for `v1alpha1.Run`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants