-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize Triggers Controller #1
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@otaviof apparently this needs to merge first before we get GitHub actions? 🤷 |
- Set up project with `kubebuilder init`. - Add Gikngo v2 and gomega for e2e testing - Vendor go code
- Update Makefile to use `go install` instead of `go get` - Use script to install kustomize (go install not supported) - Update manifests to use ko-enabled image references - Add make target to install ko, update Makefile to build and deploy with ko. - Fix namings - Use label shipwright.io/component, value "triggers" to group the deployment and services together. - Use shipwright-triggers as prefix - Rename deployment to "controller" - Add end to end test to ensure the deployment works correctly. - Add documentation on how to build, deploy, and test Triggers in a local development environment. - Add pull request template. - Add GitHub action to lint release notes, draft a release, and run CI tests.
483ed0a
to
3b0091c
Compare
alright @otaviof this is now ready for review. This gives us a "hello world" Kubebuilder controller manager, so to speak. I will have a follow-up PR that ports what I have in shipwright-io/build#1063 here. |
@adambkaplan: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Great to hear, Adam! Thank you. I'm going through your PR today, let me know if I can help with the rebase work. |
/close Will be replaced by #4 |
@adambkaplan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Dropping Support for `v1alpha1.Run`
Initialize with KubeBuilder
kubebuilder init
.Build, Deploy, and Test with ko
go install
instead ofgo get
with ko.
deployment and services together.
development environment.
tests.
/kind feature