Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update operator-sdk to v1.18 #164

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Update operator-sdk to v1.18 #164

merged 2 commits into from
Nov 2, 2023

Conversation

adambkaplan
Copy link
Member

@adambkaplan adambkaplan commented Oct 30, 2023 •
edited
Loading

Changes

Upgrade operator-sdk to v1.18, bringing in the following enhancements:

  • Ability to use image digests in the released operator bundle (v1.18.0)
  • Fix deployment to align with operator-sdk requirements.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Add `control-plane` label to operator deployment so it supports bundling with operator-sdk v1.18

@adambkaplan
Update operator-sdk to v1.18.0
d2be782 
Operator SDK v1.18.0 includes support for using image digests when
generating bundles. This is a feature the operator can take advatage of
in a follow-up enhancement to our release process.
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 30, 2023
@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 30, 2023
@openshift-ci openshift-ci bot requested review from coreydaley and otaviof October 30, 2023 14:21
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2023
@adambkaplan adambkaplan changed the title WIP - Update operator-sdk to v1.xx Update operator-sdk to v1.18 Oct 30, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2023
@adambkaplan
Copy link
Member Author

/hold

Let's cut the release for v0.12.0 before we start making changes to the deployment.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2023
@adambkaplan
Re-generate manifests with operator-sdk v1.18
d56d197 
A few changes were required to generate the bundle with v1.18.0:

- "control-plane" label on the deployment
- Main container must be named "manager"

This had cascading impacts on our kustomizations and components
that utilize label selectors.
@adambkaplan
Copy link
Member Author

/hold cancel

v0.12.0 has been tagged, we are just waiting on the final 👍 before we release.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2023
@adambkaplan
Copy link
Member Author

/assign @coreydaley

/cc @qu1queee @apoorvajagtap

@adambkaplan adambkaplan added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Nov 2, 2023
@adambkaplan adambkaplan mentioned this pull request Nov 2, 2023
Merged
4 tasks
@adambkaplan
Copy link
Member Author

/approve

Self-approving

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@coreydaley
Copy link
Contributor

The title of the pr says version 1.18.0 but the code changes seem to say 1.17.0, just want to double check.

@adambkaplan
Copy link
Member Author

The title of the pr says version 1.18.0 but the code changes seem to say 1.17.0, just want to double check.

This is a long-standing issue with these older operator-sdk releases. I raised this upstream previously, but they could not reproduce with the newer versions.

SaschaSchwarze0
SaschaSchwarze0 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SaschaSchwarze0,adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Nov 2, 2023
@openshift-ci openshift-ci bot merged commit a609357 into shipwright-io:main Nov 2, 2023
@adambkaplan adambkaplan deleted the bump-operator-sdk branch November 20, 2023 20:49
@adambkaplan
Copy link
Member Author

adambkaplan commented Nov 20, 2023 •
edited
Loading

Relates to #139

@adambkaplan adambkaplan mentioned this pull request Nov 20, 2023
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@coreydaley coreydaley Awaiting requested review from coreydaley

@otaviof otaviof Awaiting requested review from otaviof

@apoorvajagtap apoorvajagtap Awaiting requested review from apoorvajagtap

@qu1queee qu1queee Awaiting requested review from qu1queee

Assignees

@coreydaley coreydaley

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Shipwright Overview
Archived in project
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@adambkaplan @coreydaley @SaschaSchwarze0