Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported versions to README #188

Merged

Conversation

SaschaSchwarze0
Copy link
Member

Resolves #168

I added the supported versions to the Try it! section.

@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-168-k8s-version-support branch from 0f4654b to e0929d9 Compare May 12, 2020 06:37
@SaschaSchwarze0 SaschaSchwarze0 requested a review from zhangtbj May 12, 2020 06:38
@zhangtbj
Copy link
Contributor

/lgtm

@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-168-k8s-version-support branch from e0929d9 to 8167116 Compare May 12, 2020 08:33
@qu1queee
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@otaviof
Copy link
Member

otaviof commented May 12, 2020

/lgtm

@otaviof
Copy link
Member

otaviof commented May 13, 2020

/retest

@zhangtbj
Copy link
Contributor

/lgtm

@zhangtbj zhangtbj merged commit 586babb into shipwright-io:master May 13, 2020
@zhangtbj
Copy link
Contributor

There is something wrong with the issue label and we all agree the PR is ready. Let me merge this PR manually this time.

Or pls let me know if there is another good way. :)

Thanks!

@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-168-k8s-version-support branch May 13, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discuss and implement support strategy for Kubernetes and Tekton version
5 participants