Attachment Update + A few new attachments #4040
Open
+330
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DME Edit
Sprites
FalloutFalcon
added
Feature
FalloutFalcon
requested changes
Jan 27, 2025
FalloutFalcon
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds two new lists to help handle initialization for valid attachments on gun's attachment holder lists, weapon_class_attachments (for attachments specific to a gun type, eg scopes for rifles) and unique_attachments (for attachments specific to that gun eg. folding stocks on the saber) and refused_attachments (attachments the gun can't take.)
Adds secondary actions to items, currently bound to shift-space by default. Using secondary action on a gun will cycle through it's firemodes, if any.
Underbarrel guns now support hand unloading and magazines.
Underbarrel guns now come in guncases.
Underbarrel shotgun is now pumped, holds two shots, and had it's price increased to 1200.
Adds the Hognose underbarrel pistol, alof tube attachment and underbarrel energy cannon.
The Hognose and alof can be bought in outpost cargo, and the underbarrel energy cannon can be bought in the black market.
Fixes being unable to load underbarrel guns while weapons with bolts like illestren were closed.
Fixes a few typos
Why It's Good For The Game
Adding new attachments to the game isn't great right now since it operates off a single list. If a gun needs to have a different list of attachments it can take, it needs a snowflaked valid attachment list that needs to updated along with everything else whenever a new attachment is added which adds a lot of work. Organizing the lists into different categories should hopefully make things less messy to work with.
Underbarrel guns now come in cases for consistency.
The firemode hotkey was added due to feedback about how awkward it was to quickly swap firemodes to use an underbarrel gun, especially weapons with multiple firemodes since you had to moouse up and click on a HUD element. Having a hotkey should be easier.
The underbarrel shotgun was changed to make it feel better to use after feedback.
New attachments are cool I think, and work as proof of concept for the new mechanics in the update.
Changelog
🆑
add: Hognose, alof, underbarrel energy cannon
add: Underbarrel guns come in cases.
add: Secondary actions and hotkey
balance: Underbarrel shotgun holds two rounds, price increased to 1200
fix: Fixes being unable to load underbarrel guns while gun bolts were closed.
spellcheck: typos
code: new attachment lists, weapon_class_attachments, unique_attachments, refused_attachments
/:cl: