Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factions Housekeeping #3815

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Schema cleanup and validation
MarkSuckerberg committed Jan 28, 2025
commit b984ea1554c839a3ad4d7f0eed40c547472ce899
2 changes: 1 addition & 1 deletion _maps/configs/independent_dwayne.json
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@
"NATURAL",
"MERCANTILE"
],
"map_short_name": "Mk.II Dwayne-class ",
"map_short_name": "Mk.II Dwayne-class",
"map_path": "_maps/shuttles/independent/independent_dwayne.dmm",
"description": "The Dwayne is one of the older classes of ships commonly seen on the Frontier, and one of the few such classes that doesn’t also carry a reputation for nightmarish conditions or high accident rates. Originally conceived of as a “mothership” for Nanotrasen mining shuttles that could enable long-duration mining missions at minimal cost, severe budget overruns and issues with the mining shuttle docking system left Nanotrasen with a massive number of mostly-completed hulls upon the project’s cancellation. These hulls were then quickly refurbished and sold on the civilian market, where they proved an immediate success on the Frontier. Contemporary Dwaynes can typically be found carrying a variety of mining equipment and extensive modifications unique to their captains.",
"tags": [
2 changes: 1 addition & 1 deletion _maps/configs/inteq_valor.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
"map_name": "Valor-Class Field Care Cruiser",
"map_name": "Valor-class Field Care Cruiser",
"faction": "/datum/faction/inteq",
"prefix": "IRMV",
"manufacturer": "Hardline Salvage and Mining",
4 changes: 2 additions & 2 deletions _maps/configs/pgf_elated_bolide.json
Original file line number Diff line number Diff line change
@@ -3,11 +3,11 @@
"faction": "/datum/faction/pgf",
"prefix": "PGFN",
"manufacturer": "Etherbor Lihmona Shipyards",
"map_name": "Elated Bolide-Class Assault Lander",
"map_name": "Elated Bolide-class Assault Lander",
"namelists": [
"PGF"
],
"map_short_name": "Elated Bolide-Class",
"map_short_name": "Elated Bolide-class",
"description": "A somewhat stout design manufactured by the Etherbor PGFN Lihmona Navy Shipyard for service as an orbital assault ship, the Elated Bolide class has served with distinction in many minor conflicts and been sent on deployment to even more locales. Despite not carrying ship-to-ship weaponry (with the traditional mounting spot being taken up by a high-gain antenna), the Elated Bolide's Pioneers are well armed and well trained for orbital insertion, construction, and demolition.",
"tags": [
"Combat",
5 changes: 3 additions & 2 deletions _maps/ship_config_schema.json
Original file line number Diff line number Diff line change
@@ -2,18 +2,19 @@
"$schema": "https://json-schema.org/draft-07/schema",
"title": "Ship Configuration Schema",
"description": "A ship configuration, used for defining new ship classes.",
"tags": "A list of tags, used for searching ships by quality.",
"type": "object",

"properties": {
"map_name": {
"title": "Class Name",
"type": "string",
"pattern": "-class",
"description": "The name of the ship class, as viewable in-game."
},
"map_short_name": {
"title": "Shortened Class Name",
"type": "string",
"pattern": "-class$",
"description": "A shortened version of the ship class name, used in things such as the manifest.",
"maxLength": 20
},
@@ -179,5 +180,5 @@
}
},

"required": ["map_name", "map_path"]
"required": ["map_name", "map_short_name", "map_path", "faction", "job_slots"]
}