Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rock Outpost #3733

Open
wants to merge 95 commits into
base: master
Choose a base branch
from
Open

New Rock Outpost #3733

wants to merge 95 commits into from

Conversation

kaylexis
Copy link
Contributor

@kaylexis kaylexis commented Nov 11, 2024

About The Pull Request

As stated in the title. Adds a new outpost, this time, a rock planet outpost! Screenshots below.
The plan is to make more for each missing planet type except for waste and lava(maybe).
Eventually I will finish these and PR them as well.

thank you zevo with the help for the stupid indestructible walls

Why It's Good For The Game

We only have 2 rotating outposts, and I don't like either of them personally.

Changelog

🆑
add: New outpost
add: Indestructible hematite subtype
add: Safe atmos rockplanet tile subtypes
add: Safe snow tile subtypes
change: replaces indestructible plastitanium with a better one
add: proper plastitanium glass indestructible turf
/:cl:

Pictures

WOAHITSREAL

image

image

hangar

image

image

@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Nov 11, 2024
@kaylexis
Copy link
Contributor Author

woops. marked as draft

@kaylexis kaylexis marked this pull request as ready for review November 11, 2024 01:44
@kaylexis kaylexis requested a review from a team as a code owner November 11, 2024 01:44
@kaylexis
Copy link
Contributor Author

someone else can fix the smoothing issues with indestructible plastitanium glass and walls. im confused and i'm not going to bother anymore

@kaylexis
Copy link
Contributor Author

kaylexis commented Nov 11, 2024

INTEGRATION TESTS SUCCEEDED!!! IM SO HAPPY
i can finally work on the other outpost maps..

@@ -25,6 +25,9 @@
/datum/map_template/outpost/elevator_ice
name = "elevator_ice"

/datum/map_template/outpost/elevator_rock
name = "elevator_rock"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -25,6 +25,9 @@
/datum/map_template/outpost/elevator_ice
name = "elevator_ice"

/datum/map_template/outpost/elevator_rock
name = "elevator_rock"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "elevator_rock"
name = "elevator_rock"

actually the check is failing off this im stupif

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it actually failing off that shit o hmy god

@Erikafox
Copy link
Contributor

firefox_jAilbf4Kv5
this batch of tiles was spawning with rockplanet atmos.

@Erikafox
Copy link
Contributor

Erikafox commented Dec 28, 2024

upon closer inspection it appears to be /turf/open/floor/plating/asteroid/rockplanet/cracked/safe. coincidentally. those are completely broken and have no sprite (when om5 is loaded)

@kaylexis
Copy link
Contributor Author

upon closer inspection it appears to be /turf/open/floor/plating/asteroid/rockplanet/cracked/safe. coincidentally. those are completely broken and have no sprite (when om5 is loaded)

OM5 issue on the sprites, i was told it would be fixed eventually (??)
holding off on replacing them until i know if OM5 is getting un-TM'd or fullmerged
did fix the atmos issue with them though, when i changed subtyping for OM5 i forgot to add gas_mix vars to the seperated types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service. Test Merge Candidate You do it for free. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants