Skip to content

Commit

Permalink
add local packages as dependencies for werift-webrtc
Browse files Browse the repository at this point in the history
the multicast-dns package was added to werift-ice that was not being installed with
werift-webrtc. This is because we import the werift-ice code with
relative imports, i.e.
import { Connection } from "../../../ice/src";

This was making it impossible to use werift-webrtc without manually adding
multicast-dns as a dependency of whatever project is using werift-webrtc

Adding werift-ice (and the other local packages) as a dependency of
werift-webrtc fixes this issue and any future dependencies added
won't cause problems
  • Loading branch information
kevindhanna committed May 30, 2024
1 parent 1339e73 commit e8b13b5
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
10 changes: 8 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion packages/webrtc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,12 @@
"rx.mini": "^1.2.2",
"turbo-crc32": "^1.0.1",
"tweetnacl": "^1.0.3",
"uuid": "^9.0.0"
"uuid": "^9.0.0",
"werift-common": "*",
"werift-dtls": "*",
"werift-rtp": "*",
"werift-sctp": "*",
"werift-ice": "*"
},
"devDependencies": {
"@types/aes-js": "^3.1.1",
Expand Down

0 comments on commit e8b13b5

Please sign in to comment.