CADC-14066: Skaha Python Client Scaling Issues #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added sync and async client versions, concurrency limits
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 95.39% 97.43% +2.04%
==========================================
Files 18 18
Lines 521 702 +181
==========================================
+ Hits 497 684 +187
+ Misses 24 18 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
the client now supports auth bearer token, which when enabled does not perform pem certificate checks, as a result the checks for certificate have been relaxed from a FilePath which needs to exist to create a client, to a str, which is validated only if cert auth is used
…ery building logic to utils.build
…RET] from environ, this will be supported in future releases with a comprehensive environment variable support accross all configurable variables
…er of async tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkahaClientto usehttpx