This repository has been archived by the owner on Apr 15, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
KOMORAN Admin v1.1 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
구두로 전달드리긴 했지만 corpus_build/도 포함하는 걸로 👍 |
Closed
- corpus_build/ 디렉토리 유효성 검사 추가 - corpus_build/ 디렉토리 하위의 dic.word, dic.irregular, grammar.in 파일 유효성 검사 추가
- 기본 형태소 분석 메뉴 (analyze.html) - 형태소 분석 비교 메뉴 (compare.html)
UI 개선 및 Front-end 작업에 아이디어가 나오지 않아 |
shin285
reviewed
Oct 16, 2019
src/main/java/kr/co/shineware/nlp/komoran/admin/controller/MorphAnalyzeController.java
Show resolved
Hide resolved
shin285
reviewed
Oct 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코멘트 남겼습니다.
그리고 코드 외에 "형태소 분석 비교" 단계에서는 엔터키가 먹지 않네요.
9bow
commented
Oct 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코멘트 남겼습니다.
그리고 코드 외에 "형태소 분석 비교" 단계에서는 엔터키가 먹지 않네요.
조만간 확인하고 처리하겠습니다.
src/main/java/kr/co/shineware/nlp/komoran/admin/controller/MorphAnalyzeController.java
Show resolved
Hide resolved
@shin285 |
동작 확인했습니다. |
shin285
approved these changes
Oct 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KOMORAN Admin v1.1
v1.0에서 발견된 버그의 수정 및 UI/UX 개선 의견을 반영합니다.
보정 메뉴들의 입력 화면 UI 개선 보정 메뉴들의 입력 화면 UI 개선 #40(다음으로 보류)