Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an automatic fill feature to the center button in mask tab #47

Closed
wants to merge 1 commit into from

Conversation

4rnaudB
Copy link
Member

@4rnaudB 4rnaudB commented May 26, 2022

Checklist

  • I've given this PR a concise, self-descriptive, and meaningful title
  • I've linked relevant issues in the PR body
  • I've applied the relevant labels to this PR
  • I've added relevant tests for my contribution
  • I've updated the documentation and/or added correct docstrings
  • I've assigned a reviewer

Description

Automatically fills the text boxes for center button in the mask tab with the current voxel positions.

Linked Issues

@4rnaudB 4rnaudB added the enhancement New feature or request label May 26, 2022
@4rnaudB 4rnaudB requested a review from po09i May 26, 2022 20:34
@4rnaudB 4rnaudB self-assigned this May 26, 2022
@4rnaudB 4rnaudB force-pushed the ab/center-mask-auto branch from 5547419 to 041869d Compare May 27, 2022 01:00
@4rnaudB 4rnaudB force-pushed the ab/center-mask-auto branch from 9acf349 to 1cb4fdf Compare May 27, 2022 14:28
@4rnaudB 4rnaudB closed this May 27, 2022
@4rnaudB 4rnaudB reopened this May 27, 2022
@4rnaudB 4rnaudB closed this May 27, 2022
@4rnaudB 4rnaudB deleted the ab/center-mask-auto branch May 27, 2022 14:45
@jcohenadad
Copy link
Member

jcohenadad commented May 27, 2022

@4rnaudB please always add a justification when you close a PR.

In light of #49, I suggest to reconsider the relevance of adding this feature, given that filling feature already exists in FSLeyes.

Also, before taking any action, we need to discuss as a team (@po09i should have a word to say)

@4rnaudB
Copy link
Member Author

4rnaudB commented May 27, 2022

Ok, the automatic fill feature is done, but it was mostly to understand the code better. I closed the branch because I got problems trying to clean up my commits and don't want to push all this.

@po09i po09i added this to the 1.0 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Package: Plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants