Skip to content

Commit

Permalink
clean up
Browse files Browse the repository at this point in the history
Signed-off-by: shaoting-huang <[email protected]>
  • Loading branch information
shaoting-huang committed Jun 27, 2024
1 parent 5c388c1 commit ad7512c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions internal/storage/serde_events.go
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,7 @@ func (dsw *MultiFieldDeltalogStreamWriter) writeDeltalogHeaders(w io.Writer) err
return nil
}

func NewDeltalogSerializeWriterV2(partitionID, segmentID UniqueID, eventWriter *MultiFieldDeltalogStreamWriter, batchSize int,
func NewDeltalogMultiFieldWriter(partitionID, segmentID UniqueID, eventWriter *MultiFieldDeltalogStreamWriter, batchSize int,
) (*SerializeWriter[*DeleteLog], error) {
rw, err := eventWriter.GetRecordWriter()
if err != nil {
Expand Down Expand Up @@ -797,7 +797,7 @@ func NewDeltalogSerializeWriterV2(partitionID, segmentID UniqueID, eventWriter *
}, batchSize), nil
}

func NewDeltalogDeserializeReaderV2(blobs []*Blob) (*DeserializeReader[*DeleteLog], error) {
func NewDeltalogMultiFieldReader(blobs []*Blob) (*DeserializeReader[*DeleteLog], error) {
reader, err := newSimpleArrowRecordReader(blobs)
if err != nil {
return nil, err
Expand Down Expand Up @@ -832,7 +832,7 @@ func NewDeltalogDeserializeReaderV2(blobs []*Blob) (*DeserializeReader[*DeleteLo

func NewDeltalogDeserializeReaderUnified(blobs []*Blob) (*DeserializeReader[*DeleteLog], error) {
if supportMultiFieldFormat(blobs) {
return NewDeltalogDeserializeReaderV2(blobs)
return NewDeltalogMultiFieldReader(blobs)
}
return NewDeltalogDeserializeReader(blobs)
}
Expand Down
2 changes: 1 addition & 1 deletion internal/storage/serde_events_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ func TestDeltalogV2(t *testing.T) {

t.Run("test serialize deserialize", func(t *testing.T) {
eventWriter := NewMultiFieldDeltalogStreamWriter(0, 0, 0)
writer, err := NewDeltalogSerializeWriterV2(0, 0, eventWriter, 7)
writer, err := NewDeltalogMultiFieldWriter(0, 0, eventWriter, 7)
assert.NoError(t, err)

size := 10
Expand Down

0 comments on commit ad7512c

Please sign in to comment.