Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies (rails 8.0 - redis - turbo - stimulus - rubocop) #605
base: master
Are you sure you want to change the base?
Upgrade dependencies (rails 8.0 - redis - turbo - stimulus - rubocop) #605
Changes from 2 commits
31270c4
1d5db17
3f648e0
0d7e42c
bb2b6cc
5916e01
b88ffab
5d8d5a5
2a896e8
690f2b2
a76a1fe
070602b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reconsider removing database.yml sample setup
Commenting out the database.yml sample copy step might make it harder for new developers to set up the project. Rails 8.0 still uses database.yml for configuration.
Consider keeping this functionality with updated sample config:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update load_defaults to 8.0
The application is still using Rails 7.0 defaults while upgrading to Rails 8.0. This might cause inconsistencies.
Apply this change:
📝 Committable suggestion