Skip to content

Commit

Permalink
turtle-wow: add zhCN support for trueshot
Browse files Browse the repository at this point in the history
  • Loading branch information
shagu committed Feb 26, 2024
1 parent 1365368 commit 24097d7
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions modules/turtle-wow.lua
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,12 @@ pfUI:RegisterModule("turtle-wow", "vanilla", function ()
-- add trueshot to pfUI's custom casts
local player = UnitName("player")

libcast.customcast["trueshot"] = function(begin, duration)
-- add locales
pfUI_locale["enUS"]["customcast"]["TRUESHOT"] = "Trueshot"
pfUI_locale["zhCN"]["customcast"]["TRUESHOT"] = "稳固射击"
local trueshot = L["customcast"]["TRUESHOT"]

libcast.customcast[strlower(trueshot)] = function(begin, duration)
if begin then
local duration = duration or 1000

This comment has been minimized.

Copy link
@foolishyx

foolishyx Mar 4, 2024

trueshot time should be 1500ms, or 1000ms, hope it will be corrected

This comment has been minimized.

Copy link
@shagu

shagu Mar 4, 2024

Author Owner

Why 1500ms? Trueshot is 1000ms:
image

The timer works perfectly fine on my hunter.

This comment has been minimized.

Copy link
@shagu

shagu Mar 4, 2024

Author Owner

Hmm.. it actually fires at 1.4secs and sometimes at 1.3secs..
I don't understand the logic behind this. Can you explain what is delaying it?
There is something delaying it, maybe a autoshot-delay or weapon speed?

This comment has been minimized.

Copy link
@foolishyx

foolishyx via email Mar 5, 2024

This comment has been minimized.

Copy link
@foolishyx

foolishyx via email Mar 5, 2024


Expand All @@ -53,7 +58,7 @@ pfUI:RegisterModule("turtle-wow", "vanilla", function ()
local start = GetTime() + lag/1000

-- add cast action to the database
libcast.db[player].cast = "Trueshot"
libcast.db[player].cast = trueshot
libcast.db[player].rank = lastrank
libcast.db[player].start = start
libcast.db[player].casttime = duration
Expand Down

0 comments on commit 24097d7

Please sign in to comment.