globallycoherent: Propagate the MemoryQualifierSetDecoration for #6079 #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagate the kIROp_MemoryQualifierSetDecoration
memory decorations when converting from structures
to flat global resources
struct Tex
{
globallycoherent float4 bias = { 0.1, 0.3, 0.9, 1.5};
};
uniform Tex gTex;
should have the following code generated in GLSL:
coherent layout(rgba32f)
layout(binding = 2)
uniform image2D globalParams_gTex_tex_0;
This closes #6079
|
@zlatinski you need to assign the PR:non-breaking label to the PR to mark this as a non-breaking change. |
csyonghe
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate the kIROp_MemoryQualifierSetDecoration
memory decorations when converting from structures to flat global resources
struct Tex
{
globallycoherent float4 bias = { 0.1, 0.3, 0.9, 1.5};
};
uniform Tex gTex;
should have the following code generated in GLSL:
coherent layout(rgba32f)
layout(binding = 2)
uniform image2D globalParams_gTex_tex_0;
This closes #6079
pr: non-breaking