Uncomment a previously failing test case #6303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case now parses after the following PR was merged. shader-slang#6281
csyonghe
reviewed
Feb 6, 2025
| @@ -745,8 +745,7 @@ void computeMain() | |||
| nb = input[463]; | |||
| nc = input[464]; | |||
| output[208] = uint(na >> nb < nc); | |||
| // error 39999: expected a generic when using '<...>' (found: 'uint') | |||
| // output[209] = uint(na < nb >> nc); | |||
| output[209] = uint(na < nb >> nc); | |||
There was a problem hiding this comment.
Do you also need to modify the expected result?
There was a problem hiding this comment.
No, it was already 0. (na, nb, nc = 3,8,7 and it should be evaluated like like 3 < (8 >> 7) = 3 < 0 = 0)
csyonghe
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case now parses after the following PR was merged. #6281