Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): correct button positioning in collapsed state #7

Closed
wants to merge 1 commit into from

Conversation

artemavrin
Copy link

  • Improve button display consistency when sidebar is collapsed to icon

- Improve button display consistency when sidebar is collapsed to icon
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-tailwind-v4 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:56am

@shadcn
Copy link
Owner

shadcn commented Jan 30, 2025

Something is up the sidebar on Tailwind v4. Taking a look now. I can't reproduce same on v3: https://ui.shadcn.com/sink

@shadcn
Copy link
Owner

shadcn commented Jan 30, 2025

@artemavrin Looks like a tailwind-merge issue.

@henry-guido
Copy link

henry-guido commented Feb 1, 2025

I can solve by removing the important

group-data-[collapsible=icon]:p-2 instead of group-data-[collapsible=icon]:p-2!

I hope it helps you

@shadcn
Copy link
Owner

shadcn commented Feb 3, 2025

@artemavrin I believe #13 fixed this. It was a tailwind-merge issue.

@shadcn shadcn closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants