-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple-file support to vcfpartition #252
Conversation
Looks like there were some ruff issues because I forgot to setup pre-commit. Should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Will-Tyler!
Good to merge after a rebase (I like a linear commit history)
The docs build is very fragile, it needs a good overhaul (#238) once we've figured out a better structure for the actual documentation (#239). |
Docs failure is because of numpy 2.0 issues, these should go away once you rebase. |
Thanks, I just rebased this branch. I would like to merge this pull request before #253. |
Description
This pull request adds support for multiple VCF/BCF files to the vcfpartition command and closes #212.
When the user specifies multiple VCF/BCF files, vcfpartition interprets the number of partitions argument as the total number of partitions among all the files. The partitions are distributed evenly among the files.
Let me know if we should add a section to the vcfpartition that describes how to partition multiple files.
Testing
I added some unit tests to test the changes to the vcfpartition CLI.
I tried to check the documentation changes manually by building the documentation (running
make -C docs
from the project directory), but I encountered this error:I didn't spend much time trying to resolve this, but if you know the fix, that would help!