Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple-file support to vcfpartition #252

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

Will-Tyler
Copy link
Contributor

Description

This pull request adds support for multiple VCF/BCF files to the vcfpartition command and closes #212.

When the user specifies multiple VCF/BCF files, vcfpartition interprets the number of partitions argument as the total number of partitions among all the files. The partitions are distributed evenly among the files.

Let me know if we should add a section to the vcfpartition that describes how to partition multiple files.

Testing

I added some unit tests to test the changes to the vcfpartition CLI.

I tried to check the documentation changes manually by building the documentation (running make -C docs from the project directory), but I encountered this error:

rm -fR sample.vcz
asciinema-automation cast_scripts/vcf2zarr_convert.sh _static/vcf2zarr_convert.cast
make: asciinema-automation: No such file or directory
make: *** [_static/vcf2zarr_convert.cast] Error 1

I didn't spend much time trying to resolve this, but if you know the fix, that would help!

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 98.843% (-0.04%) from 98.884%
when pulling 21f142f on Will-Tyler:issue-212
into 31a5935 on sgkit-dev:main.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 98.886% (+0.002%) from 98.884%
when pulling 21f142f on Will-Tyler:issue-212
into 31a5935 on sgkit-dev:main.

@Will-Tyler
Copy link
Contributor Author

Looks like there were some ruff issues because I forgot to setup pre-commit. Should be good now.

Copy link
Contributor

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Will-Tyler!

Good to merge after a rebase (I like a linear commit history)

@jeromekelleher
Copy link
Contributor

I tried to check the documentation changes manually by building the documentation (running make -C docs from the project directory), but I encountered this error:

The docs build is very fragile, it needs a good overhaul (#238) once we've figured out a better structure for the actual documentation (#239).

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 98.843% (-0.04%) from 98.884%
when pulling 99d7f7f on Will-Tyler:issue-212
into 31a5935 on sgkit-dev:main.

@jeromekelleher
Copy link
Contributor

Docs failure is because of numpy 2.0 issues, these should go away once you rebase.

@Will-Tyler
Copy link
Contributor Author

Thanks, I just rebased this branch. I would like to merge this pull request before #253.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 98.843% (-0.04%) from 98.884%
when pulling 6a573a6 on Will-Tyler:issue-212
into a75091e on sgkit-dev:main.

@jeromekelleher jeromekelleher merged commit d683a31 into sgkit-dev:main Jun 19, 2024
9 of 11 checks passed
@Will-Tyler Will-Tyler deleted the issue-212 branch June 19, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for multiple files to vcfpartition
3 participants