Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work-arounds for Vivado bugs #4

Merged
merged 2 commits into from
Feb 1, 2020
Merged

Work-arounds for Vivado bugs #4

merged 2 commits into from
Feb 1, 2020

Conversation

sgherbst
Copy link
Owner

This PR addresses several issues:

  1. FIXED_TO_FLOAT is now a macro, rather than a function, due to a Vivado bug involved mixtures of signed data types and real numbers in (bug reported here).
  2. FLOAT_TO_FIXED is also now a macro, due to a different Vivado bug. That bug has to due with casting real numbers to longints (reported here).
  3. CALC_EXP is now a macro as well. Not strictly necessary, but since the above two functions were problematic, it seemed prudent to convert CALC_EXP to a macro as well. clog2_math is the only remaining function; it should stay a function because the macro version is very ugly (as seen in earlier versions of svreal).

@sgherbst sgherbst changed the title Work arounds for Vivado bugs Work-arounds for Vivado bugs Jan 31, 2020
@gabrielrutsch gabrielrutsch merged commit 9ad97f6 into master Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants