Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a bunch of the "synth" patches #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asikwus
Copy link

@asikwus asikwus commented Aug 18, 2024

I got inspired to recreate some classic GM synth patches, without this in mind actually. But when I found out about this project, it was like they were destined for this. The samples they're made with are either the sfz 2.0s internal waveforms or completely original sounds, made from scratch with OpenMPT, Audacity and the synth-plugin Vital.

I quickly ported over some of them and designed some more on the spot, like Synth Strings 2, Lead 1 (square), Lead 2 (sawtooth) and Pad 3 (polysynth).

There are problems with the absolute cutoff values on the filters and the panning in current bank-file, which are not present in the individual preset-files. I dunno how to fix that.

Also, many of them are using the same samples but with respective clones in their sample folder, which is unnecessary waste of space. I think there should be a sample folder called Common where samples shared by multiple instruments can be located.

@jlearman
Copy link
Collaborator

jlearman commented Oct 13, 2024

Thanks for doing this. Sorry I didn't see it earlier. I'll review this week or next. Feel free to post back if I forget.

@jlearman
Copy link
Collaborator

jlearman commented Oct 23, 2024

Regarding files shared by multiple instruments: one option is to simply use samples from another instrument, rather than duplicating them. I'll look into doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants