Ensure JSON content type in performRequestOnCurrentHost #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the export of the externals (cpr, jsoncpp)
|
Hello @benlabbe, thank you for your participation on Elasticlient library. At first, I would like to say sorry for my late reply. Few minutes ago I merged the fix (5d91a85) which should ensure that JSON content type is sent when request's body is not empty. I also modified tests for this issue. Does this solve the issue for you? This pull request goes from your master branch, so I'm not entirely sure which commits are relevant. Thank you |
|
Hello,
Thank you for answering me.
You should have a look to the following commits I made in my branch. They
made me the use of elasticlient much simpler as an external library in my
own project, and here I mean includind and linking to the lib through cmake
packages.
You might merge these commits also, if these functionalities are useful in
your context. Tell me if you prefer a merge request from me instead of
merging on your own.
With regards
Benjamin
Le mar. 22 mai 2018 à 10:59, Martin Bumba <[email protected]> a
écrit :
… Hello @benlabbe <https://github.com/benlabbe>, thank you for your
participation on Elasticlient library. At first, I would like to say sorry
for my late reply. Few minutes ago I merged the fix (5d91a85
<5d91a85>)
which should ensure that JSON content type is sent when request's body is
not empty. I also modified tests for this issue.
Does this solve the issue for you? This pull request goes from your master
branch, so I'm not entirely sure which commits are relevant. Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AkVeGhePVRVILGgy8VwPtBsp38VS-g2Iks5t09N7gaJpZM4TIMHG>
.
|
updateDocument feature for SameIndexBulkData
Proxy can by used to - debug connection - change headers on the flight when needed
Co-Authored-By: kwach <[email protected]>
Co-Authored-By: kwach <[email protected]>
Co-Authored-By: kwach <[email protected]>
Co-Authored-By: kwach <[email protected]>
Providing a way to connect to ES cluster via proxy server
Externals updated to latest versions.
…Scroll. Signed-off-by: Martin Bumba <[email protected]>
…syntax Fixes issue seznam#13
While creating a document with an explicit identifier, Elasticsearch needs to perform a check whether the same id already exists within the same shard. This patch makes setting document id optional. And using auto-generated ids by leaving _id parameter, which makes indexing faster. Signed-off-by: Ladislav Macoun <[email protected]>
Signed-off-by: Ladislav Macoun <[email protected]>
Changed document identifier to be optional
The library will be build depending on the BUILD_SHARED_LIBS[1] flag. This enables to build and link this library statically. [1]: https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html Signed-off-by: Ladislav Macoun <[email protected]>
For long string the validation is expensive, and often not necessary since the doc could be validated during its constructions/deserialization. The option default to true, so previous API should not be broken. Signed-off-by: Ladislav Macoun <[email protected]>
…oice. Added BUILD_SHARED_LIBS to readme.
…ssary. So versions are set only when building shared library.
…adding optional argument. When ABI breaks this commit could be "reverted"...
# Conflicts: # src/CMakeLists.txt # src/client.cc
# Conflicts: # src/CMakeLists.txt # src/client.cc
# Conflicts: # src/client.cc
|
Dear Martin, I recently merged all your contributions since 2018 into my master branch. Still my pull request is relevant from my point of view because I updated the cmake config scripts for an easier package distribution / integration in other C++ projects . Any remarks ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.