v0.0.18 | Supports Texture Coordinates and Normals #17
Conversation
... Co-Authored-By: Faru Nuri Sönmez <[email protected]>
william-silversmith
force-pushed
the
master
branch
4 times, most recently
from
660b1df to
92a72f2
Compare
|
Hi Faru! I'm the new maintainer for this repo and I'll be happy to review your PR! I'm a bit less experienced with the Draco spec compared with the library creator, so I might need some tips to help review. ^_^ I'll leave some comments on the PR. Would you mind also adding an automated test? Thanks!! Sorry it took so long to get this reviewed. |
| encoding_test = DracoPy.encode_mesh_to_buffer(mesh_object.points, mesh_object.faces) | ||
| print('number of faces in original file: {0}'.format(len(mesh_object.tex_coord))) | ||
| print('number of normal in original file: {0}'.format(len(mesh_object.normals))) | ||
| encoding_test = DracoPy.encode_mesh_to_buffer(mesh_object.points, mesh_object.face) |
| print('number of points in original file: {0}'.format(len(mesh_object.points))) | ||
| print('number of faces in original file: {0}'.format(len(mesh_object.faces))) | ||
| encoding_test = DracoPy.encode_mesh_to_buffer(mesh_object.points, mesh_object.faces) | ||
| print('number of faces in original file: {0}'.format(len(mesh_object.tex_coord))) |
There was a problem hiding this comment.
Shouldn't this be the number of texture coordinates?
| print('number of faces in original file: {0}'.format(len(mesh_object.faces))) | ||
| encoding_test = DracoPy.encode_mesh_to_buffer(mesh_object.points, mesh_object.faces) | ||
| print('number of faces in original file: {0}'.format(len(mesh_object.tex_coord))) | ||
| print('number of normal in original file: {0}'.format(len(mesh_object.normals))) |
There was a problem hiding this comment.
normal -> normals
| @@ -69,7 +68,7 @@ def read(fname): | |||
| setuptools.Extension( | |||
| 'DracoPy', | |||
| sources=[ os.path.join(src_dir, 'DracoPy.cpp') ], | |||
| depends=[ os.path.join(src_dir, 'DracoPy.h') ], | |||
| depends=[ os.path.join(src_dir, 'DracoPy.h'), os.path.join(src_dir, 'DracoPy.pyx')], | |||
There was a problem hiding this comment.
I don't think this is right. The pyx is only necessary for generating the DracoPy.cpp files
| @@ -35,11 +35,18 @@ namespace DracoFunctions { | |||
| }; | |||
|
|
|||
| MeshObject decode_buffer(const char *buffer, std::size_t buffer_len) { | |||
|
|
|||
| std::cout << "Decode Buffer" << "Begin" << std::endl; | |||
There was a problem hiding this comment.
Please either hide the std::couts behind a verbose flag or remove them. This library is often used in large deployments of thousands of CPUs.
| @@ -70,7 +74,7 @@ class FileTypeException(Exception): | |||
| class EncodingFailedException(Exception): | |||
| pass | |||
|
|
|||
| def encode_mesh_to_buffer(points, faces, quantization_bits=14, compression_level=1, quantization_range=-1, quantization_origin=None, create_metadata=False): | |||
| def encode_mesh_to_buffer(points, faces, normals, quantization_bits=14, compression_level=1, quantization_range=-1, quantization_origin=None, create_metadata=False): | |||
There was a problem hiding this comment.
This seems like a breaking change. Can normals be given a default value that is handled gracefully?
|
Thanks again for this valuable contribution! |
|
Hi Faru! I adopted some of your changes (the normal decode) and gave you a credit in the setup.py file! I was working rapidly so I didn't adopt the textures as I wasn't sure how to test it. Thanks for your contribution! |
|
Sorry, closed by mistake when I meant to comment. |
|
@william-silversmith Thank you very much for further upgrading the library, would it be possible to add UV / texture support as well? If you need an example script / files I could provide it to you for testing. |
|
Hi Florian, I'd be happy to consider adding it. A script and data would
help tremendously!
…On Sat, Apr 9, 2022, 12:05 PM Florian Bruggisser ***@***.***> wrote:
@william-silversmith <https://github.com/william-silversmith> Thank you
very much for further upgrading the library, would it be possible to add UV
/ texture support as well? If you need an example script / files I could
provide it to you for testing.
—
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATGQSJKC3USLB6B7XANIADVEGTFFANCNFSM44K7IY7Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
william-silversmith
force-pushed
the
master
branch
3 times, most recently
from
0c52fd3 to
27f89cc
Compare
#5 Can it encode normal or uv?
Co-Authored-By: Faru Nuri Sönmez [email protected]