Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent avatar colors #13

Merged
merged 25 commits into from
Jan 17, 2025
Merged

Consistent avatar colors #13

merged 25 commits into from
Jan 17, 2025

Conversation

Miki-Session
Copy link
Collaborator

@Miki-Session Miki-Session commented Nov 18, 2024 •
edited
Loading

  • new isSameColor function allows color comparisons within a "humans-can't-tell-the-difference" tolerance
  • new test specs for verifying consistent placeholder avatar colors
    • a user's color is the same on their own device and a contact's device
    • a user's color is the same across their own linked devices

@Miki-Session
Copy link
Collaborator Author

looks like eslint failing is a known issue
eslint/eslint#19134

Bilb
Bilb reviewed Dec 16, 2024
View reviewed changes
run/test/specs/utils/check_colour.ts Outdated Show resolved Hide resolved
run/test/specs/utils/check_colour.ts Outdated Show resolved Hide resolved
run/test/specs/utils/check_colour.ts Outdated Show resolved Hide resolved
run/test/specs/linked_device_avatar_color.spec.ts Outdated Show resolved Hide resolved
run/test/specs/linked_device_avatar_color.spec.ts Outdated Show resolved Hide resolved
run/test/specs/utils/check_colour.ts Outdated Show resolved Hide resolved
run/test/specs/check_avatar_color.spec.ts Outdated Show resolved Hide resolved
run/test/specs/check_avatar_color.spec.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@Miki-Session Miki-Session requested a review from Bilb January 8, 2025 05:11
Bilb
Bilb requested changes Jan 8, 2025
View reviewed changes
run/test/specs/utils/check_colour.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@Bilb
Copy link
Collaborator

Bilb commented Jan 10, 2025

LGTM

burtonemily
burtonemily requested changes Jan 13, 2025
View reviewed changes
run/test/specs/check_avatar_color.spec.ts Outdated Show resolved Hide resolved
run/test/specs/check_avatar_color.spec.ts Outdated Show resolved Hide resolved
run/test/specs/linked_device_avatar_color.spec.ts Outdated Show resolved Hide resolved
run/test/specs/locators/home.ts Show resolved Hide resolved
burtonemily
burtonemily approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@burtonemily burtonemily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nicely done

@burtonemily burtonemily merged commit f6b263f into session-foundation:main Jan 17, 2025
1 check passed
@Miki-Session Miki-Session deleted the consistent-account-colors branch January 17, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bilb Bilb Bilb approved these changes

@burtonemily burtonemily burtonemily approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Miki-Session @Bilb @burtonemily