chore: add no useless return to eslint conf

also fix camelCase for var name
session-foundation · Nov 18, 2024 · a7f8671 · a7f8671
1 parent 832635d
commit a7f8671
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -23,7 +23,8 @@ export default tseslint.config(
   },
   {
     rules: {
-      'no-unused-vars': 'off',
+      'no-unused-vars': 'off', // we have @typescript-eslint/no-unused-vars enabled below
+      'no-else-return': 'error',
       '@typescript-eslint/no-floating-promises': 'error',
       '@typescript-eslint/no-unsafe-member-access': 'off',
       '@typescript-eslint/no-explicit-any': 'off',

diff --git a/run/types/DeviceWrapper.ts b/run/types/DeviceWrapper.ts
@@ -1319,7 +1319,7 @@ export class DeviceWrapper {
     }
     if (this.isIOS()) {
       const testMessage = 'Testing-document-1';
-      const spongebobsBirthday = '199905010700.00';
+      const spongeBobsBirthday = '199905010700.00';
       await this.clickOnByAccessibilityID('Attachments button');
       await sleepFor(100);
       await clickOnCoordinates(this, InteractionPoints.DocumentKeyboardOpen);
@@ -1333,7 +1333,7 @@ export class DeviceWrapper {
 
       if (!testDocument) {
         await runScriptAndLog(
-          `touch -a -m -t ${spongebobsBirthday} 'run/test/specs/media/test_file.pdf'`
+          `touch -a -m -t ${spongeBobsBirthday} 'run/test/specs/media/test_file.pdf'`
         );
 
         await runScriptAndLog(
@@ -1428,7 +1428,7 @@ export class DeviceWrapper {
   }
 
   public async uploadProfilePicture() {
-    const spongebobsBirthday = '199805010700.00';
+    const spongeBobsBirthday = '199805010700.00';
     await this.clickOnElementAll(new UserSettings(this));
     // Click on Profile picture
     await this.clickOnElementAll(new UserSettings(this));
@@ -1443,7 +1443,7 @@ export class DeviceWrapper {
       });
       if (!profilePicture) {
         await runScriptAndLog(
-          `touch -a -m -t ${spongebobsBirthday} 'run/test/specs/media/profile_picture.jpg'`
+          `touch -a -m -t ${spongeBobsBirthday} 'run/test/specs/media/profile_picture.jpg'`
         );
 
         await runScriptAndLog(
@@ -1520,9 +1520,8 @@ export class DeviceWrapper {
         maxWait: 500,
       });
       return Boolean(spaceBar);
-    } else {
-      console.log(`Not an iOS device: shouldn't use this function`);
     }
+    console.log(`Not an iOS device: shouldn't use this function`);
   }
 
   public async mentionContact(platform: SupportedPlatformsType, contact: User) {