Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverless Website Component: Added CloudFront Feture #5

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Durgaprasad-Budhwani
Copy link
Contributor

This PR is the continuation of other PR at serverless/domain https://github.com/serverless-components/domain/pull/6

This changeset passes s3 bucket name and CloudFront information to serverless/domain component.

For the consumer, there will be few CloudFront properties

myWebsite:
  component: "@serverless/website"
  inputs:
    cloudFront: # (Optional)
        waitForCreateDistribution: true  # (Optional) wait for create CloudFront distribution to complete
        waitForUpdateDistribution: false # (Optional) wait for update CloudFront distribution to complete
        customOrigin: true # (Optional)  wait for custom origin to avoid s3 bucket redirect during cloudfront creation

CustomOrigin is required to avoid CloudFront url redirection to s3 website redirection for initial 30-40 minutes.

@eahefnawy
Copy link
Member

Thanks again @Durgaprasad-Budhwani ... as mentioned in #6 ... we can't accept this change as it'd slow down the deployment of the entire stack. So we'll close this PR as well.

Also, the website component is a great simple abstraction on top of everything AWS. It could even be used with different providers in the future. So I'd try to avoid introducing CloudFront specific inputs unless we absolutely have to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants