Update two emoji functions with roles field #3095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
GnomedDev
requested changes
Jan 19, 2025
| @@ -317,7 +317,7 @@ impl GuildId { | |||
| builder.execute(http, self).await | |||
| } | |||
|
|
|||
| /// Creates an emoji in the guild with a name and base64-encoded image. | |||
| /// Creates an emoji in the guild with a name and base64-encoded image and set of roles. | |||
There was a problem hiding this comment.
Can this documentation be expanded a little to explain what the roles passed do? I had to check ddev docs to realize it restricts the emoji to only be usable by those roles.
There was a problem hiding this comment.
Should I add the section about it above the permission line comment? Something like "The emoji will only be visible to those that has the role to use it."? It's the furthest I can think of right now while understanding the Discord docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was discussed/brought up in Discord a month ago for missing support for roles field in
create_emojiandedit_emoji.I feel like I am missing something prior to creating this PR but feel free to correct me on it though.
Yes, it is also tested on the bot before forking and creating the PR.