Make changes based on PR feedback

serenity-rs · Jan 19, 2025 · 90f2c5b · 90f2c5b
1 parent ebe2933
commit 90f2c5b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/model/guild/guild_id.rs b/src/model/guild/guild_id.rs
@@ -342,14 +342,15 @@ impl GuildId {
         http: &Http,
         name: &str,
         image: &str,
-        roles: Vec<RoleId>,
+        roles: Option<Vec<RoleId>>,
         reason: Option<&str>,
     ) -> Result<Emoji> {
         #[derive(serde::Serialize)]
         struct CreateEmoji<'a> {
             name: &'a str,
             image: &'a str,
-            roles: Vec<RoleId>,
+            #[serde(skip_serializing_if = "Option::is_none")]
+            roles: Option<Vec<RoleId>>,
         }
 
         let body = CreateEmoji {
@@ -591,6 +592,7 @@ impl GuildId {
         #[derive(serde::Serialize)]
         struct EditEmoji<'a> {
             name: &'a str,
+            #[serde(skip_serializing_if = "Option::is_none")]
             roles: Option<Vec<RoleId>>,
         }