Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react.js #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update react.js #3

wants to merge 1 commit into from

Conversation

yarinkos
Copy link

@yarinkos yarinkos commented May 9, 2021

Adding function with value return

@yarinkos
Copy link
Author

yarinkos commented May 9, 2021

@tmacwill , is this addition look fine ?

@tmacwill
Copy link
Member

apologies for the delayed response! it looks like this has two <%cursor%> elements—I think you only want one?

@yarinkos
Copy link
Author

yarinkos commented Jun 8, 2021

I think more about bootstrap functional component like, with the argument as a default return value :
const Headline = ({ value }) => { return {value}; };
But you don't have to accept it,maybe this one is too simple

Copy link

@ryanpeach ryanpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and return value in this snippet seems redundant as value is not a templated variable. Also it's a little long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants