Version up of pytype and type error handling #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koki-Kazaore
commented
Dec 31, 2024
| pip install "flake8==6.1.0" && flake8 main*.py app/*.py |
There was a problem hiding this comment.
Upgrade to support validate.sh
Koki-Kazaore
commented
Dec 31, 2024
| pip install "pytype==2024.10.11" boto3 && pytype *.py |
There was a problem hiding this comment.
Upgrade to support validate.sh
seratch
reviewed
Jan 9, 2025
app/bolt_listeners.py
Outdated
| .get("selected_option") | ||
| .get("value", "modal") | ||
| ) | ||
| selected_option = extract_state_value(payload, "where-to-share-summary").get("selected_option") or {} |
There was a problem hiding this comment.
I do understand this change may be necessary to make pytype happy. However, the selected_option must exist in this scenario, so I don't want to have fallback like or {} here. Instead, replacing get("selected_option") with ["selected_option"] could make more sense.
There was a problem hiding this comment.
Thank you for your review. I have corrected the issues you mentioned and made improvements to other parts as well.
Koki-Kazaore
force-pushed
the
#57_pytype_errors
branch
from
3778de9 to
d01b060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Version up of pytype and type error handling.
Issue
#57