Skip to content

Commit

Permalink
Send initial yarn install stderr to /dev/null to avoid false warnings. (
Browse files Browse the repository at this point in the history
  • Loading branch information
stephenh authored Jun 7, 2020
1 parent 4d3f7e9 commit 20436d6
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- v1-dependencies-{{ checksum "package.json" }}
- v1-dependencies-

- run: yarn install || echo "ignore failure"
- run: yarn install
- run: ./pbjs.sh
- run: ./integration/pbjs.sh

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: install dependencies
run: yarn install || echo "ignore failure"
run: yarn install
- name: pbjs
run: ./pbjs.sh
- name: Prepare Integration
Expand Down
2 changes: 1 addition & 1 deletion README.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ Building

`ts-proto` does not use `pbjs` at runtime, but we do use it in the `ts-proto` build process (to bootstrap the types used to parse the incoming protobuf metadata types, as well as for the test suite to ensure the `ts-proto` implementations match the `ts-proto`).

After running `yarn install` (which will fail in `yarn test` on the first time), run `./pbjs.sh` to create the bootstrap types, and `./integration/pbjs.sh` to create the integration test types. These pbjs-generated files are not currently checked in.
After running `yarn install`, run `./pbjs.sh` to create the bootstrap types, and `./integration/pbjs.sh` to create the integration test types. These pbjs-generated files are not currently checked in.

After this the tests should pass.

Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"protoc-gen-ts_proto": "./protoc-gen-ts_proto"
},
"scripts": {
"prepare": "yarn build && yarn test",
"build": "yarn tsc",
"setup": "./pbjs.sh && ./integration/pbjs.sh && ./integration/update-bins.sh && ./integration/codegen.sh",
"test": "yarn jest -c jest.config.js",
Expand Down
6 changes: 6 additions & 0 deletions publish.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/usr/bin/env bash

yarn build
(cd ./integration || exit; ./codegen.sh)
yarn test
yarn publish

0 comments on commit 20436d6

Please sign in to comment.