fix: node price related tests

sentinel-official · Nov 6, 2024 · 39a99e7 · 39a99e7
1 parent b3e5b24
commit 39a99e7
Show file tree

Hide file tree

Showing 7 changed files with 236 additions and 235 deletions.
diff --git a/types/test_utils.go b/types/test_utils.go
@@ -32,25 +32,26 @@ var (
 	TestDenomOne     = "one"
 	TestDenomTwo     = "two"
 
-	TestIntEmpty    = sdkmath.Int{}
-	TestIntNegative = sdkmath.NewInt(-1000)
-	TestIntZero     = sdkmath.NewInt(0)
-	TestIntPositive = sdkmath.NewInt(1000)
-
-	TestCoinEmpty          = sdk.Coin{}
-	TestCoinEmptyDenom     = sdk.Coin{Denom: TestDenomEmpty, Amount: TestIntPositive}
-	TestCoinInvalidDenom   = sdk.Coin{Denom: TestDenomInvalid, Amount: TestIntPositive}
-	TestCoinEmptyAmount    = sdk.Coin{Denom: TestDenomOne, Amount: TestIntEmpty}
-	TestCoinNegativeAmount = sdk.Coin{Denom: TestDenomOne, Amount: TestIntNegative}
-	TestCoinZeroAmount     = sdk.Coin{Denom: TestDenomOne, Amount: TestIntZero}
-	TestCoinPositiveAmount = sdk.Coin{Denom: TestDenomOne, Amount: TestIntPositive}
-
-	TestCoinsNil            sdk.Coins = nil
-	TestCoinsEmpty                    = sdk.Coins{}
-	TestCoinsEmptyDenom               = sdk.Coins{TestCoinEmptyDenom}
-	TestCoinsInvalidDenom             = sdk.Coins{TestCoinInvalidDenom}
-	TestCoinsEmptyAmount              = sdk.Coins{TestCoinEmptyAmount}
-	TestCoinsNegativeAmount           = sdk.Coins{TestCoinNegativeAmount}
-	TestCoinsZeroAmount               = sdk.Coins{TestCoinZeroAmount}
-	TestCoinsPositiveAmount           = sdk.Coins{TestCoinPositiveAmount}
+	TestIntEmpty = sdkmath.Int{}
+	TestIntNeg   = sdkmath.NewInt(-1000)
+	TestIntZero  = sdkmath.NewInt(0)
+	TestIntPos   = sdkmath.NewInt(1000)
+
+	TestCoinEmpty      = sdk.Coin{}
+	TestCoinEmptyZero  = sdk.Coin{Amount: TestIntZero, Denom: TestDenomEmpty}
+	TestCoinEmptyPos   = sdk.Coin{Amount: TestIntPos, Denom: TestDenomEmpty}
+	TestCoinInvalidPos = sdk.Coin{Amount: TestIntPos, Denom: TestDenomInvalid}
+	TestCoinOneEmpty   = sdk.Coin{Amount: TestIntEmpty, Denom: TestDenomOne}
+	TestCoinOneNeg     = sdk.Coin{Amount: TestIntNeg, Denom: TestDenomOne}
+	TestCoinOneZero    = sdk.Coin{Amount: TestIntZero, Denom: TestDenomOne}
+	TestCoinOnePos     = sdk.Coin{Amount: TestIntPos, Denom: TestDenomOne}
+
+	TestCoinsNil        sdk.Coins = nil
+	TestCoinsEmpty                = sdk.Coins{}
+	TestCoinsEmptyPos             = sdk.Coins{TestCoinEmptyPos}
+	TestCoinsInvalidPos           = sdk.Coins{TestCoinInvalidPos}
+	TestCoinsOneEmpty             = sdk.Coins{TestCoinOneEmpty}
+	TestCoinsOneNeg               = sdk.Coins{TestCoinOneNeg}
+	TestCoinsOneZero              = sdk.Coins{TestCoinOneZero}
+	TestCoinsOnePos               = sdk.Coins{TestCoinOnePos}
 )
diff --git a/x/deposit/types/v1/deposit_test.go b/x/deposit/types/v1/deposit_test.go
@@ -80,23 +80,23 @@ func TestDeposit_Validate(t *testing.T) {
 			"10 bytes address",
 			fields{
 				Address: base.TestBech32AccAddr10Bytes,
-				Coins:   base.TestCoinsPositiveAmount,
+				Coins:   base.TestCoinsOnePos,
 			},
 			false,
 		},
 		{
 			"20 bytes address",
 			fields{
 				Address: base.TestBech32AccAddr20Bytes,
-				Coins:   base.TestCoinsPositiveAmount,
+				Coins:   base.TestCoinsOnePos,
 			},
 			false,
 		},
 		{
 			"30 bytes address",
 			fields{
 				Address: base.TestBech32AccAddr30Bytes,
-				Coins:   base.TestCoinsPositiveAmount,
+				Coins:   base.TestCoinsOnePos,
 			},
 			false,
 		},
@@ -120,47 +120,47 @@ func TestDeposit_Validate(t *testing.T) {
 			"empty denom coins",
 			fields{
 				Address: base.TestBech32AccAddr20Bytes,
-				Coins:   base.TestCoinsEmptyDenom,
+				Coins:   base.TestCoinsEmptyPos,
 			},
 			true,
 		},
 		{
 			"invalid denom coins",
 			fields{
 				Address: base.TestBech32AccAddr20Bytes,
-				Coins:   base.TestCoinsInvalidDenom,
+				Coins:   base.TestCoinsInvalidPos,
 			},
 			true,
 		},
 		{
 			"nil amount coins",
 			fields{
 				Address: base.TestBech32AccAddr20Bytes,
-				Coins:   base.TestCoinsEmptyAmount,
+				Coins:   base.TestCoinsOneEmpty,
 			},
 			true,
 		},
 		{
 			"negative amount coins",
 			fields{
 				Address: base.TestBech32AccAddr20Bytes,
-				Coins:   base.TestCoinsNegativeAmount,
+				Coins:   base.TestCoinsOneNeg,
 			},
 			true,
 		},
 		{
 			"zero amount coins",
 			fields{
 				Address: base.TestBech32AccAddr20Bytes,
-				Coins:   base.TestCoinsZeroAmount,
+				Coins:   base.TestCoinsOneZero,
 			},
 			true,
 		},
 		{
 			"positive amount coins",
 			fields{
 				Address: base.TestBech32AccAddr20Bytes,
-				Coins:   base.TestCoinsPositiveAmount,
+				Coins:   base.TestCoinsOnePos,
 			},
 			false,
 		},