-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Langchain file #175
Conversation
Hi @thearyanag , my pr is ready for review. Thanks! |
hey @DogukanGun - can you rebase it once? looks like it does not have the latest changes from main branch + during rebase don't commit the docs pls |
hey @DogukanGun -we more wanted that each tool and action present under src/langchain and src/actions should be grouped into proper folders given the protocol name
re-writing the issue to be more clear rewrote the issue to avoid any confusion, thanks |
aaf099e
to
fc92d44
Compare
Hi @thearyanag , thank you for the review! I have made the changes in the langchain folder as per your suggestions. Once you approve the approach for the changes in langchain, I will proceed to update the tool and action folders as well. |
Hi @thearyanag, is this implementation correct ? If it is, then I can finish actions folder also. |
hey @DogukanGun - the direction is absolutely correct ! |
Hi @thearyanag , thanks for your review. I finished the implementation and the pr is ready for review. |
Hi @thearyanag , I noticed that the accepted PR seems quite similar to mine, with the main difference being the index files in each subfolder. I was wondering if there were any other differences that led to that PR being merged instead? I’d appreciate any feedback you can provide! 😊 |
hey @DogukanGun , both were quite similar indeed but
|
Thank you for the feedback! 😊 I understand now, and I’ll focus on working on other PRs. |
refactor langchain file.
This pull request was created for https://app.gib.work/bounties/0b78790e-6d48-4ec3-b67f-46c96dac6b7d in an attempt to solve a bounty #173 . Payment for the bounty is immediately sent to the contributor after merge.