fix(lookup-git-tag): prevent SIGPIPE issue #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floriantz
approved these changes
Jun 5, 2024
rdelgatte
approved these changes
Jun 5, 2024
jdassonvil
force-pushed
the
jerome/fix-sigpipe
branch
from
79844d2 to
b7fda4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a concurrency issue in
git tag -lwhich leads to the pipe still being written when readers are done.The issue seems to arise as the tag list is getting big enough.
Looking at "the internet" this issue seems related to the internal use of grep by git: https://stackoverflow.com/questions/19120263/why-exit-code-141-with-grep-q
This fix ensures that the
git tag -lcommand has finished before piping the result to the next commands.See also https://tldp.org/LDP/lpg/node20.html