[SENP-648] feat(ecs-deploy): improve consistency of workflows parameters #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdassonvil
force-pushed
the
jerome/optionnal-docker-args
branch
2 times, most recently
from
4dba87e to
89c2952
Compare
jdassonvil
changed the title
jdassonvil
force-pushed
the
jerome/optionnal-docker-args
branch
from
89c2952 to
78d4aba
Compare
jdassonvil
changed the title
jdassonvil
force-pushed
the
jerome/optionnal-docker-args
branch
from
78d4aba to
70718d6
Compare
floriantz
approved these changes
Apr 12, 2024
Comment on lines
+41
to
+43
| use_version_as_docker_image_tag: | ||
| type: boolean | ||
| default: true |
There was a problem hiding this comment.
Could you add the required block to make the behaviour explicit here, I admit I don't remember which is the default and we add it whether we set it to false or true in the other fields.
floriantz
reviewed
Apr 12, 2024
.github/workflows/ecs-deploy-v2.yml
Outdated
| current_version: ${{ steps.current_version.outputs.image_tag }} | ||
| deployed_version: ${{ inputs.docker_image_tag }} | ||
| former_version: ${{ steps.ecs_lookup.outputs.image_tag || steps.git_hash.output.previous }} | ||
| new_version: ${{ inputs.docker_image_tag || steps.git_hash.output.current }} |
There was a problem hiding this comment.
Are the lint errors due to the linter having difficulty with understanding the output of the new workflow ?
jdassonvil
force-pushed
the
jerome/optionnal-docker-args
branch
from
146f69e to
9c6e045
Compare
jdassonvil
force-pushed
the
jerome/optionnal-docker-args
branch
from
72f8f95 to
8d53dfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ecs-deploy:
docker_image_tagis now optional on theecs-deploydeploy workflow, this will make applications that have a static image tag easier to configure.docker_image_tagis now deprecated in favour ofversion, this term is closer to the level of abstraction of this workflow.versionone might setuse_version_as_docker_image_tagtofalseto avoid the version being passed as docker_image_tag to the terraform apply (default istrue, this is the most common usage)deployment-notification:
current_versionis now deprecated in favour offormer_versionanddeployed_versionin favour ofnew_version, this should reduce the ambiguity when using this action.