Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node-modules-cache): add architecture to cache key #168

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jdassonvil
Copy link
Contributor

@jdassonvil jdassonvil commented Oct 10, 2024

This PR adds the cpu architecture to the cache key. Some libraries (e.g. esbuild) are compiled for the target cpu architecture so we can't share the same cache between runners with different architecture.

@jdassonvil jdassonvil requested a review from a team as a code owner October 10, 2024 15:14
Copy link

@jdassonvil jdassonvil merged commit f1ac33f into master Oct 11, 2024
1 check passed
@jdassonvil jdassonvil deleted the jerome/add-arch-cache branch October 11, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants