feat: replace packr and add basic cache headers

Since packr have been deprecated in favor of go:embed for quite some
time now I have replaced it with plain go:embed functionality which
makes it more future proof.

The only downside is that go:embed can use relativ paths only, that's
why I have moved the web/dist folder into api/public.

Besides that I have refactored the static asset handling which includes
basic last modification and cache control headers to improve the cache
cache behavior for static assets.

.gitignore

@@ -5,7 +5,7 @@ web/public/css/*.*
 web/public/html/**/*.*
 web/public/fonts/*.*
 web/.nyc_output
-web/dist/**/*
+api/public/**/*
 /config.json
 /.dredd/config.json
 /database.boltdb
@@ -18,7 +18,6 @@ node_modules/
 /semaphore.iml
 /bin/
 
-*-packr.go
 util/version.go
 /vendor/
 /coverage.out
@@ -30,4 +29,4 @@ util/version.go
 
 .vscode
 __debug_bin*
-.task/
+.task/

Taskfile.yml

@@ -56,7 +56,6 @@ tasks:
       GORELEASER_VERSION: "0.183.0"
       GOLINTER_VERSION: "1.46.2"
     cmds:
-      - go install github.com/gobuffalo/packr/[email protected]
       - go install github.com/snikch/goodman/cmd/goodman@latest
       - go install github.com/go-swagger/go-swagger/cmd/[email protected]
       - '{{ if ne OS "windows" }} sh -c "curl -L https://github.com/goreleaser/goreleaser/releases/download/v{{ .GORELEASER_VERSION }}/goreleaser_$(uname -s)_$(uname -m).tar.gz | tar -xz -C $(go env GOPATH)/bin goreleaser"{{ else }} {{ end }}'
@@ -84,25 +83,17 @@ tasks:
       - babel.config.js
       - vue.config.js
     generates:
-      - dist/css/*.css
-      - dist/js/*.js
-      - dist/index.html
-      - dist/favicon.ico
+      - ../api/public/css/*.css
+      - ../api/public/js/*.js
+      - ../api/public/index.html
+      - ../api/public/favicon.ico
     cmds:
       - npm run build
 
   compile:be:
-    desc: Runs Packr for static assets
-    sources:
-      - web/dist/*
-      - db/migrations/*
-    generates:
-      - db/db-packr.go
-      - api/api-packr.go
+    desc: Generate the version
     cmds:
-      - mkdir -p web/dist
       - go run util/version_gen/generator.go {{ if .TAG }}{{ .TAG }}{{ else }}{{ if .SEMAPHORE_VERSION }}{{ .SEMAPHORE_VERSION }}{{ else }}{{ .BRANCH }}-{{ .SHA }}-{{ .TIMESTAMP }}{{ if .DIRTY }}-dirty{{ end }}{{ end }}{{end}}
-      - packr
     vars:
       TAG:
         sh: git name-rev --name-only --tags --no-undefined HEAD 2>/dev/null | sed -n 's/^\([^^~]\{1,\}\)\(\^0\)\{0,1\}$/\1/p'
@@ -148,7 +139,7 @@ tasks:
   lint:be:
     # --errors
     cmds:
-      - golangci-lint run --skip-files "\w*(-packr.go)" --disable goconst --timeout 240s ./...
+      - golangci-lint run --disable goconst --timeout 240s ./...
 
   test:
     cmds:

Taskfile_windows.yml

@@ -2,7 +2,6 @@ version: '2'
 tasks:
   compile:be:
     cmds:
-      - packr
       - go run util/version_gen/generator.go 1
   build:local:
     dir: cli

api/router.go

@@ -1,22 +1,28 @@
 package api
 
 import (
+	"bytes"
+	"embed"
 	"fmt"
 	"net/http"
 	"os"
+	"path"
 	"strings"
+	"time"
 
 	"github.com/ansible-semaphore/semaphore/api/helpers"
 	"github.com/ansible-semaphore/semaphore/api/projects"
 	"github.com/ansible-semaphore/semaphore/api/runners"
 	"github.com/ansible-semaphore/semaphore/api/sockets"
 	"github.com/ansible-semaphore/semaphore/db"
 	"github.com/ansible-semaphore/semaphore/util"
-	"github.com/gobuffalo/packr"
 	"github.com/gorilla/mux"
 )
 
-var publicAssets2 = packr.NewBox("../web/dist")
+var startTime = time.Now().UTC()
+
+//go:embed public/*
+var publicAssets embed.FS
 
 // StoreMiddleware WTF?
 func StoreMiddleware(next http.Handler) http.Handler {
@@ -51,15 +57,6 @@ func pongHandler(w http.ResponseWriter, r *http.Request) {
 	w.Write([]byte("pong"))
 }
 
-func notFoundHandler(w http.ResponseWriter, r *http.Request) {
-	w.Header().Set("Access-Control-Allow-Origin", r.Header.Get("Origin"))
-	w.Header().Set("Access-Control-Allow-Credentials", "true")
-	w.WriteHeader(http.StatusNotFound)
-	//nolint: errcheck
-	w.Write([]byte("404 not found"))
-	fmt.Println(r.Method, ":", r.URL.String(), "--> 404 Not Found")
-}
-
 // Route declares all routes
 func Route() *mux.Router {
 	r := mux.NewRouter()
@@ -311,75 +308,86 @@ func debugPrintRoutes(r *mux.Router) {
 	}
 }
 
-// nolint: gocyclo
 func servePublic(w http.ResponseWriter, r *http.Request) {
 	webPath := "/"
 	if util.WebHostURL != nil {
-		webPath = util.WebHostURL.RequestURI()
+		webPath = util.WebHostURL.Path
+		if !strings.HasSuffix(webPath, "/") {
+			webPath += "/"
+		}
 	}
 
-	path := r.URL.Path
+	reqPath := r.URL.Path
+	apiPath := path.Join(webPath, "api")
 
-	if path == webPath+"api" || strings.HasPrefix(path, webPath+"api/") {
-		w.WriteHeader(http.StatusNotFound)
+	if reqPath == apiPath || strings.HasPrefix(reqPath, apiPath) {
+		http.Error(w, http.StatusText(http.StatusNotFound), http.StatusNotFound)
 		return
 	}
 
-	if !strings.Contains(path, ".") {
-		path = "/index.html"
+	if !strings.Contains(reqPath, ".") {
+		serveFile(w, r, "index.html")
+		return
 	}
 
-	path = strings.Replace(path, webPath, "", 1)
-	split := strings.Split(path, ".")
-	suffix := split[len(split)-1]
+	newPath := strings.Replace(
+		reqPath,
+		webPath,
+		"",
+		1,
+	)
 
-	var res []byte
-	var err error
+	serveFile(w, r, newPath)
+}
 
-	res, err = publicAssets2.MustBytes(path)
+func serveFile(w http.ResponseWriter, r *http.Request, name string) {
+	res, err := publicAssets.ReadFile(
+		fmt.Sprintf("public/%s", name),
+	)
 
 	if err != nil {
-		notFoundHandler(w, r)
+		http.Error(
+			w,
+			http.StatusText(http.StatusNotFound),
+			http.StatusNotFound,
+		)
+
 		return
 	}
 
-	// replace base path
-	if util.WebHostURL != nil && path == "/index.html" {
+	if util.WebHostURL != nil && name == "index.html" {
 		baseURL := util.WebHostURL.String()
+
 		if !strings.HasSuffix(baseURL, "/") {
 			baseURL += "/"
 		}
-		res = []byte(strings.Replace(string(res),
-			"<base href=\"/\">",
-			"<base href=\""+baseURL+"\">",
-			1))
+
+		res = []byte(
+			strings.Replace(
+				string(res),
+				`<base href="/">`,
+				fmt.Sprintf(`<base href="%s">`, baseURL),
+				1,
+			),
+		)
 	}
 
-	contentType := "text/plain"
-	switch suffix {
-	case "png":
-		contentType = "image/png"
-	case "jpg", "jpeg":
-		contentType = "image/jpeg"
-	case "gif":
-		contentType = "image/gif"
-	case "js":
-		contentType = "application/javascript"
-	case "css":
-		contentType = "text/css"
-	case "woff":
-		contentType = "application/x-font-woff"
-	case "ttf":
-		contentType = "application/x-font-ttf"
-	case "otf":
-		contentType = "application/x-font-otf"
-	case "html":
-		contentType = "text/html"
+	if !strings.HasSuffix(name, ".html") {
+		w.Header().Add(
+			"Cache-Control",
+			fmt.Sprintf("max-age=%d, public, must-revalidate, proxy-revalidate", 24*time.Hour),
+		)
 	}
 
-	w.Header().Set("content-type", contentType)
-	_, err = w.Write(res)
-	util.LogWarning(err)
+	http.ServeContent(
+		w,
+		r,
+		name,
+		startTime,
+		bytes.NewReader(
+			res,
+		),
+	)
 }
 
 func getSystemInfo(w http.ResponseWriter, r *http.Request) {

db/sql/SqlDb.go

@@ -2,19 +2,20 @@ package sql
 
 import (
 	"database/sql"
+	"embed"
 	"fmt"
+	"reflect"
+	"regexp"
+	"strconv"
+	"strings"
+
 	log "github.com/Sirupsen/logrus"
 	"github.com/ansible-semaphore/semaphore/db"
 	"github.com/ansible-semaphore/semaphore/util"
 	"github.com/go-gorp/gorp/v3"
 	_ "github.com/go-sql-driver/mysql" // imports mysql driver
-	"github.com/gobuffalo/packr"
 	_ "github.com/lib/pq"
 	"github.com/masterminds/squirrel"
-	"reflect"
-	"regexp"
-	"strconv"
-	"strings"
 )
 
 type SqlDb struct {
@@ -28,7 +29,9 @@ create table ` + "`migrations`" + ` (
 	` + "`notes`" + ` text null
 );
 `
-var dbAssets = packr.NewBox("./migrations")
+
+//go:embed migrations/*.sql
+var dbAssets embed.FS
 
 func containsStr(arr []string, str string) bool {
 	for _, a := range arr {

db/sql/migration.go

@@ -2,12 +2,13 @@ package sql
 
 import (
 	"fmt"
-	log "github.com/Sirupsen/logrus"
-	"github.com/ansible-semaphore/semaphore/db"
-	"github.com/go-gorp/gorp/v3"
 	"regexp"
 	"strings"
 	"time"
+
+	log "github.com/Sirupsen/logrus"
+	"github.com/ansible-semaphore/semaphore/db"
+	"github.com/go-gorp/gorp/v3"
 )
 
 var (
@@ -32,14 +33,14 @@ func getVersionErrPath(version db.Migration) string {
 	return version.HumanoidVersion() + ".err.sql"
 }
 
-// getVersionSQL takes a path to an SQL file and returns it from packr as
+// getVersionSQL takes a path to an SQL file and returns it from embed.FS
 // a slice of strings separated by newlines
 func getVersionSQL(path string) (queries []string) {
-	sql, err := dbAssets.MustString(path)
+	sql, err := dbAssets.ReadFile(path)
 	if err != nil {
 		panic(err)
 	}
-	queries = strings.Split(strings.ReplaceAll(sql, ";\r\n", ";\n"), ";\n")
+	queries = strings.Split(strings.ReplaceAll(string(sql), ";\r\n", ";\n"), ";\n")
 	for i := range queries {
 		queries[i] = strings.Trim(queries[i], "\r\n\t ")
 	}
@@ -186,7 +187,7 @@ func (d *SqlDb) ApplyMigration(migration db.Migration) error {
 
 // TryRollbackMigration attempts to rollback the database to an earlier version if a rollback exists
 func (d *SqlDb) TryRollbackMigration(version db.Migration) {
-	data := dbAssets.Bytes(getVersionErrPath(version))
+	data, _ := dbAssets.ReadFile(getVersionErrPath(version))
 	if len(data) == 0 {
 		fmt.Println("Rollback SQL does not exist.")
 		fmt.Println()

deployment/semaphore.spec

@@ -37,7 +37,6 @@ then
     PATH="$HOME/go/bin:$PATH"
 fi
 export PATH
-##go install github.com/gobuffalo/packr/v2@latest
 go-task all
 
 cat > ansible-semaphore.service <<EOF

go.mod

@@ -9,7 +9,6 @@ require (
 	github.com/go-gorp/gorp/v3 v3.0.2
 	github.com/go-ldap/ldap/v3 v3.4.1
 	github.com/go-sql-driver/mysql v1.4.1
-	github.com/gobuffalo/packr v1.10.4
 	github.com/google/go-github v17.0.0+incompatible
 	github.com/gorilla/context v1.1.1
 	github.com/gorilla/handlers v1.4.2
@@ -18,10 +17,10 @@ require (
 	github.com/gorilla/websocket v1.4.1
 	github.com/lib/pq v1.2.0
 	github.com/masterminds/squirrel v0.0.0-20170825200431-a6b93000bd21
+	github.com/pkg/errors v0.9.1
 	github.com/robfig/cron/v3 v3.0.1
 	github.com/snikch/goodman v0.0.0-20171125024755-10e37e294daa
 	github.com/spf13/cobra v1.2.1
-	github.com/stretchr/testify v1.7.0
 	go.etcd.io/bbolt v1.3.2
 	golang.org/x/crypto v0.3.0
 	golang.org/x/oauth2 v0.7.0
@@ -33,7 +32,6 @@ require (
 	github.com/ProtonMail/go-crypto v0.0.0-20221026131551-cf6655e29de4 // indirect
 	github.com/acomagu/bufpipe v1.0.3 // indirect
 	github.com/cloudflare/circl v1.1.0 // indirect
-	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/emirpasic/gods v1.18.1 // indirect
 	github.com/go-asn1-ber/asn1-ber v1.5.1 // indirect
 	github.com/go-git/gcfg v1.5.0 // indirect
@@ -48,8 +46,6 @@ require (
 	github.com/lann/builder v0.0.0-20180216234317-1b87b36280d0 // indirect
 	github.com/lann/ps v0.0.0-20150810152359-62de8c46ede0 // indirect
 	github.com/mitchellh/go-homedir v1.1.0 // indirect
-	github.com/pkg/errors v0.9.1 // indirect
-	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/sergi/go-diff v1.1.0 // indirect
 	github.com/spf13/pflag v1.0.5 // indirect
 	github.com/xanzy/ssh-agent v0.3.3 // indirect
@@ -61,5 +57,4 @@ require (
 	gopkg.in/airbrake/gobrake.v2 v2.0.9 // indirect
 	gopkg.in/gemnasium/logrus-airbrake-hook.v2 v2.1.2 // indirect
 	gopkg.in/warnings.v0 v0.1.2 // indirect
-	gopkg.in/yaml.v3 v3.0.0 // indirect
 )

go.sum

@@ -122,8 +122,6 @@ github.com/go-ldap/ldap/v3 v3.4.1 h1:fU/0xli6HY02ocbMuozHAYsaHLcnkLjvho2r5a34BUU
 github.com/go-ldap/ldap/v3 v3.4.1/go.mod h1:iYS1MdmrmceOJ1QOTnRXrIs7i3kloqtmGQjRvjKpyMg=
 github.com/go-sql-driver/mysql v1.4.1 h1:g24URVg0OFbNUTx9qqY1IRZ9D9z3iPyi5zKhQZpNwpA=
 github.com/go-sql-driver/mysql v1.4.1/go.mod h1:zAC/RDZ24gD3HViQzih4MyKcchzm+sOG5ZlKdlhCg5w=
-github.com/gobuffalo/packr v1.10.4 h1:k/aQq1+9UlSxfr9+QXz1sQ8vJVFTXqrEDdKgeonlt4Y=
-github.com/gobuffalo/packr v1.10.4/go.mod h1:rYwMLC6NXbAbkKb+9j3NTKbxSswkKLlelZYccr4HYVw=
 github.com/godbus/dbus/v5 v5.0.4/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA=
 github.com/gogo/protobuf v1.3.2/go.mod h1:P1XiOD3dCwIKUDQYPy72D8LYyHL2YPYrpS2s69NZV8Q=
 github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b/go.mod h1:SBH7ygxi8pfUlaOkMMuAQtPIUF8ecWP5IEl/CR7VP2Q=