-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit profile page #136
Merged
Merged
Edit profile page #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2575e34
to
9b00af4
Compare
Naapperas
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be careful with the amount of div
s you use. Ask @ttoino if you have any doubts regarding that matter.
7ae820c
to
be0ee0c
Compare
Naapperas
previously approved these changes
Sep 30, 2023
@pedrosilva17 one thing I noticed: perhaps we could make the font of this page's text bold, or at least make it stand out more. |
be0ee0c
to
c1f17c8
Compare
c1f17c8
to
81f9dc7
Compare
Naapperas
approved these changes
Sep 30, 2023
toni-santos
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108
Currently similar to the default edit profile page from Laravel, now in a different route. The sentences in here need to be added to #75 (I can do that after this is merged, if you want @Naapperas)