Daniel tech submission #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Test Submission
This PR contains a minimum of 3 bug fixes, and feature addition.
Bug fixes
type=passwordto the password input./project/:idapp route was throwing an error. This was due to the/project/:idAPI route returning an array of projects, instead of a single project. This was fixed by changingModel.find()toModel.findOne()Feature
The feature I developed was a back button allowing users to navigate back to the login page.
Why this feature?
It was a very quick win.
Feedback
This project was well organized and easy to navigate. My main difficulty was using JavaScript without any type checking, at least JSDoc would be appreciated.