fix: update gradle files for 0.73 support #917
Conversation
Current lib should just work with 0.73 but taking preliminary steps to keep up to date based on the work specified [here](react-native-community/discussions-and-proposals#671) And in particular on the revised outputs of [create-react-native-library CLI](https://github.com/callstack/react-native-builder-bob/blob/fc8744092501ba00fd11bdb69e1ecb46fbb63c0f/packages/create-react-native-library/templates/native-common/android/build.gradle) - Updated build.gradle and gradle.properties to match new CLI outputs - Added new AndroidManifest.xml without namespace - Added namespace in build.gradle only if Gradle 7.3+
|
|
||
| repositories { | ||
| google() | ||
| jcenter() | ||
| mavenCentral() |
There was a problem hiding this comment.
Was curious about this - found https://developer.android.com/build/jcenter-migration which explains why you needed to do this 😄
(And I guess it also just matches the new template)
There was a problem hiding this comment.
I was actually surprised that we hadn't done this before!
I remember it used to be very noisy in analytics-android/kotlin
Yes, the E2E actually tests against 0.72 Also of note that we're not bumping any major versions or using any particular features of Java/gradle so people should just be able to override with lower numbers if needed just as before |
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.19.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.6.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.4.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.7.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Current lib should just work with 0.73 but taking preliminary steps to keep up to date based on the work specified here
And in particular on the revised outputs of create-react-native-library CLI
Fixes #915