Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Niall/braze debounce update #912

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Niall/braze debounce update #912

merged 4 commits into from
Feb 8, 2024

Conversation

niallzato
Copy link
Contributor

Our current logic for comparing the last seen traits and the current traits does not actually compare values. Our current logic to compare the traits is just checking the referential equality:

this.lastSeenTraits?.traits === event.traits

Referential equality can be determined with equality operators such as strict equality (===) or coercive equality (==) and also by using Object.is() functions, but determining deep equality is tricky as the objects can be nested.

Customer issue: #907

Copy link
Contributor

@alanjcharles alanjcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Can you write a test for it in identify.test.ts ?

@oscb oscb merged commit 285a3bd into master Feb 8, 2024
3 of 6 checks passed
@oscb oscb deleted the niall/braze_debounce_update branch February 8, 2024 18:28
@oscb
Copy link
Contributor

oscb commented Feb 26, 2024

🎉 This PR is included in version 1.1.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@oscb oscb added the released label Feb 26, 2024
@oscb
Copy link
Contributor

oscb commented Feb 26, 2024

🎉 This PR is included in version 2.19.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@oscb
Copy link
Contributor

oscb commented Feb 26, 2024

🎉 This PR is included in version 1.3.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@oscb
Copy link
Contributor

oscb commented Feb 26, 2024

🎉 This PR is included in version 1.1.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@oscb
Copy link
Contributor

oscb commented Feb 26, 2024

🎉 This PR is included in version 0.6.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@oscb
Copy link
Contributor

oscb commented Feb 26, 2024

🎉 This PR is included in version 1.1.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@oscb
Copy link
Contributor

oscb commented Feb 26, 2024

🎉 This PR is included in version 0.4.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@oscb
Copy link
Contributor

oscb commented Feb 26, 2024

🎉 This PR is included in version 0.7.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@oscb
Copy link
Contributor

oscb commented Feb 26, 2024

🎉 This PR is included in version 1.2.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants