Add support for hasUnmappedDestinations #905
Conversation
| .every(([_, v]) => this.containsConsentSettings(v)) | ||
| ) | ||
| !this.isConsentFeatureSetup() || | ||
| !(noneConsented && !this.hasUnmappedDestinations()) |
There was a problem hiding this comment.
There was a problem hiding this comment.
I think the isConsentFeatureSetup is an interesting one to have here. Cause potentially it might throw a "false" positive and let all events flow if the settings object is not loaded (f.e. you have bad connection). I guess this is more of an scenario where we should let the client control what they want to do in that scenario. Not sure really if this has been talked in Consent Management before. Anyway. We don't have to solve this yet.
I think the line !(noneConsented && !this.hasUnmappedDestinations()) could be rewritten as !noneConsented || !this.hasUnmappedDestinations(). If I'm understanding correctly the spec you want to let things flow if everything is consented or when there's at least an unmapped destination.
There was a problem hiding this comment.
another idea to avoid many negations which make it harder to understand is to swap noneConsented to allConsented so that you don't have to negate.
| .every(([_, v]) => this.containsConsentSettings(v)) | ||
| ) | ||
| !this.isConsentFeatureSetup() || | ||
| !(noneConsented && !this.hasUnmappedDestinations()) |
There was a problem hiding this comment.
I think the isConsentFeatureSetup is an interesting one to have here. Cause potentially it might throw a "false" positive and let all events flow if the settings object is not loaded (f.e. you have bad connection). I guess this is more of an scenario where we should let the client control what they want to do in that scenario. Not sure really if this has been talked in Consent Management before. Anyway. We don't have to solve this yet.
I think the line !(noneConsented && !this.hasUnmappedDestinations()) could be rewritten as !noneConsented || !this.hasUnmappedDestinations(). If I'm understanding correctly the spec you want to let things flow if everything is consented or when there's at least an unmapped destination.
| .every(([_, v]) => this.containsConsentSettings(v)) | ||
| ) | ||
| !this.isConsentFeatureSetup() || | ||
| !(noneConsented && !this.hasUnmappedDestinations()) |
There was a problem hiding this comment.
another idea to avoid many negations which make it harder to understand is to swap noneConsented to allConsented so that you don't have to negate.
|
Had a discussion with Seth on this, lets keep the expressions as-is. They are compliant with the spec. |
## @segment/analytics-react-native [2.18.0-beta.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0-beta.1) (2023-12-15) ### Features * add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596)) * consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332)) * RN 0.72 Upgrade ([03f13a1](03f13a1)) ### Dependencies * **@segment/sovran-react-native:** upgraded to 1.1.0-beta.1
## @segment/analytics-react-native [2.18.0](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0) (2023-12-15) ### Features * add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596)) * consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332)) * RN 0.72 Upgrade ([03f13a1](03f13a1)) ### Dependencies * **@segment/sovran-react-native:** upgraded to 1.1.0
## @segment/analytics-react-native [2.18.0-beta.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0-beta.1) (2023-12-15) ### Features * add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596)) * consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332)) * RN 0.72 Upgrade ([03f13a1](03f13a1))
## @segment/analytics-react-native [2.18.0-beta.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0-beta.1) (2023-12-15) ### Features * add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596)) * consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332)) * RN 0.72 Upgrade ([03f13a1](03f13a1)) ### Dependencies * **@segment/sovran-react-native:** upgraded to 1.1.0-beta.1
## @segment/analytics-react-native [2.18.0](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0) (2024-02-01) ### Features * add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596)) * consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332)) * RN 0.72 Upgrade ([03f13a1](03f13a1)) ### Bug Fixes * remove circular dependency in ConsentPlugin ([71e7eae](71e7eae)) ### Dependencies * **@segment/sovran-react-native:** upgraded to 1.1.0
Implements the spec as explained here
Parity established with segment-integrations/analytics-swift-consent@6563d95