Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braze plugin does not successfully de-duplicate Identify calls #907

Closed
Jack-Gill-TH opened this issue Dec 14, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@Jack-Gill-TH
Copy link
Contributor

  • analytics-react-native version: 2.15.0
  • Integrations versions (if used): @segment/analytics-react-native-plugin-braze: 0.5.4
  • React Native version: 0.68.7
  • iOS or Android or both? Both

Steps to reproduce
Make an initial call to identify with a specific set of traits
Make a second call to identify with the same set of traits

Expected behavior
Identify is not forwarded to braze

Actual behavior
Identify is forwarded to braze


This is because the code that checks for a duplicate payload just performs a referential equality on the two traits objects:

this.lastSeenTraits?.traits === event.traits

I think it's fairly unlikely that this code will be called each time with the same object reference, so this should be updated to perform some kind of deep equality.

@Jack-Gill-TH Jack-Gill-TH added the bug Something isn't working label Dec 14, 2023
@oscb
Copy link
Contributor

oscb commented Mar 18, 2024

Closing. Fix is released in v0.6.1

@oscb oscb closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants