review feedback and fix tests

segmentio · Jan 4, 2024 · 5fd7915 · 5fd7915
1 parent 863e3b4
commit 5fd7915
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/core/src/plugins/ConsentPlugin.ts b/packages/core/src/plugins/ConsentPlugin.ts
@@ -54,7 +54,11 @@ export class ConsentPlugin extends Plugin {
     let lastDeviceAttrs = analytics.context.get()?.device;
     analytics.context.onChange((c) => {
       const newAttrs = c?.device;
-      if (JSON.stringify(lastDeviceAttrs) !== JSON.stringify(newAttrs)) {
+      if (
+        newAttrs?.adTrackingEnabled !== lastDeviceAttrs?.adTrackingEnabled ||
+        newAttrs?.advertisingId !== lastDeviceAttrs?.advertisingId ||
+        newAttrs?.trackingStatus !== lastDeviceAttrs?.trackingStatus
+      ) {
         this.notifyConsentChange();
       }
       lastDeviceAttrs = newAttrs;

diff --git a/packages/plugins/plugin-onetrust/src/__tests__/OneTrust.test.ts b/packages/plugins/plugin-onetrust/src/__tests__/OneTrust.test.ts
@@ -1,4 +1,5 @@
 import {
+  Context,
   DestinationPlugin,
   Plugin,
   PluginType,
@@ -192,7 +193,7 @@ describe('OneTrustPlugin', () => {
             C004: false,
           },
         },
-      }) as unknown,
+      }) as unknown as Context,
     });
   });
 });