WIP: Update to OSPRay 1.8.4 #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also updates Embree to 3.5.2 and ISPC to 1.10.0
|
Actually, this shouldn't be merged quite yet. Forgot to include the PBNJ and Enchiladas submodule updates to use latest versions. |
|
PBNJ is updated, Enchiladas shouldn't need anything special. But this will have to wait for OSPRay 1.8.5. There is a CMake bug in 1.8.4 caused by OSPRay being a git submodule. I submitted a fix for it, but it won't be out until 1.8.5. We could use a devel commit, but I would rather have a tagged release commit for the submodule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading all the way from OSPRay 1.3.1 to 1.8.4! The example still compiles and runs, along with my own test case. However, now there are (several) warnings during compilation as PBNJ is using deprecated API calls. By OSPRay 2 I expect these to break entirely, so PBNJ/Enchiladas would need to update API calls and/or use the scene graph.