-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mandatory test 6.1.35 #215
base: 196-csaf-2.1
Are you sure you want to change the base?
Conversation
Coverage after merging 197-csaf-2.1-mandatory-test-6.1.35 into 196-csaf-2.1-exclude-unimplemented-tests-from-test-suite
Coverage Report
|
I'll review after #220 is merged |
}) | ||
} | ||
|
||
return ctx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result errors seems to be duplicated with switched categories
[
{
"instancePath": "/vulnerabilities/0/remediations/1",
"message": "contradicting remediation categories for product id "CSAFPID-9080700": no_fix_planned, vendor_fix"
},
{
"instancePath": "/vulnerabilities/0/remediations/1",
"message": "contradicting remediation categories for product id "CSAFPID-9080700": vendor_fix, no_fix_planned"
}
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I addressed this issue using a Set
which holds the already checked categories.
afe5008
to
06bc757
Compare
Coverage after merging 197-csaf-2.1-mandatory-test-6.1.35 into 196-csaf-2.1
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.