updated ajv-formats to version 3.0.0-rc.0 #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging feat/ajv-format-fix into main
Coverage Report |
tschmidtb51
requested changes
May 4, 2023
There was a problem hiding this comment.
I just tested it and it still doesn't work as it should. See #20 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #20
In order to fix this I upgraded ajv-formats to pre-release version 3.0.0
In this version the offset in the datetime string is required and omitting it causes an error.
In @domachine's comment he was worried about the correctness of his testing results, but all of them were RFC3339 compliant (see page 7 section 5.6).