date-time bug

[tschmidtb51]

The same bug as secvisogram/secvisogram#216 (see ajv-validator/ajv-formats#55) applies here. We should use ajv-validator/ajv-formats#49 version 3.0.0 even if it is not stable yet.

[domachine]

I'm a bit confused. I just upgraded the ajv-formats library and did a quick test using the nodejs repl with the following result:

> var Ajv = require('ajv')
undefined
> var ajv = new Ajv()
undefined
> require('ajv-formats')(ajv)
...
> ajv.validate({ type: 'string', format: 'date-time' }, '2020-01-01 20:00:00.000')
false
> ajv.validate({ type: 'string', format: 'date-time' }, '2020-01-01 20:00:00.000Z')
true
> ajv.validate({ type: 'string', format: 'date-time' }, '2020-01-01T20:00:00.000Z')
true

It seems that it still doesn't validate the date-time correctly.

[tschmidtb51]

Me too... I thought it had been fixed with version 3: ajv-validator/ajv-formats#55

[tschmidtb51]

As discussed today.

[tschmidtb51]

As described in ajv-validator/ajv-formats#55 the RFC 3339 requires by ABNF and description the use of T as a separator and the use of an timezone. The note

NOTE: ISO 8601 defines date and time separated by "T".
Applications using this syntax may choose, for the sake of
readability, to specify a full-date and full-time separated by
(say) a space character.

is not changing the ABNF but telling a potential representation in the GUI resp. pointing to ISO 8601. Therefore, the ajv-formats needs to be fixed.

The following examples are invalid:

'2020-01-01 20:00:00.000', '2020-01-01 20:00:00.000Z', '2023-05-04\t01:14:00+21:00', '2023-05-04\r01:14:10+16:20', '2023-05-04\n01:14:21+09:50', '2023-05-04\n01:14:21-04:31', '2023-05-04t01:14:21-04:31:00'

The following examples are fully valid:

'2020-01-01T20:00:00.000Z', '2020-01-01T20:00:00.000Z', '2023-05-04T01:14:00+21:00', '2023-05-04T01:14:10+16:20', '2023-05-04T01:14:21+09:50', '2023-05-04T01:14:21-04:31', '2023-05-04T01:14:21-23:59'

The following examples are valid but should not be produced by Secvisogram:

'2020-01-01t20:00:00.000Z', '2020-01-01T20:00:00.000z', '2023-05-04t01:14:00+21:00', '2023-05-04t01:14:10+16:20', '2023-05-04t01:14:21+09:50', '2023-05-04t01:14:21-04:31', '2023-05-04t01:14:21z'

Please provide an appropriate PR to ajv-formats.

[tschmidtb51]

@domachine Maybe worth having a look again? I found this PR: BSI-Bund/secvisogram#76