Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add OIDC-URL env variable #198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Add OIDC-URL env variable #198

wants to merge 2 commits into from

Conversation

mfd2007
Copy link
Contributor

@mfd2007 mfd2007 commented Aug 27, 2024

Added a additional env variable to be more flexible.

@mfd2007
fix: OIDC-URL was generated from env variables.
ec0bdb3 
Added a additional env variable.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

Test Results

303 tests   303 ✅  37s ⏱️
 23 suites    0 💤
 23 files      0 ❌

Results for commit be5a64e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

Overall Project 90.12% 🍏

There is no coverage information present for the Files changed

@mfd2007 mfd2007 mentioned this pull request Aug 27, 2024
Open
@mfd2007 mfd2007 requested a review from tschmidtb51 August 27, 2024 09:16
@mfd2007
Copy link
Contributor Author

mfd2007 commented Jan 27, 2025

Problem is decribed in #99. There was an inadvertent reference to PR #195.

@mfd2007 mfd2007 mentioned this pull request Jan 27, 2025
Closed
rainer-exxcellent
rainer-exxcellent requested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@rainer-exxcellent rainer-exxcellent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the solutions but I think the pull request is only marginally related to the issue #/99

@github-actions GitHub Actions
Copy link
Contributor

Overall Project 90% 🍏

There is no coverage information present for the Files changed

@mfd2007
Copy link
Contributor Author

mfd2007 commented Jan 28, 2025

I like the solutions but I think the pull request is only marginally related to the issue #/99

You are right. We should merge this PR and I will look for the solution of #99 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainer-exxcellent rainer-exxcellent rainer-exxcellent requested changes

@tschmidtb51 tschmidtb51 Awaiting requested review from tschmidtb51

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfd2007 @rainer-exxcellent