Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Furhtor Refactroing #123

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
a1329e7
#121 Introduce Our Own Exception Type Hierarchy
Weltraumschaf Feb 16, 2024
9c3bd78
#121 Remove Checked Exception to Provide a Cleaner API
Weltraumschaf Feb 16, 2024
1a2f61a
#121 Use Latest Version 17 of Java
Weltraumschaf Feb 16, 2024
a662260
#121 Javadoc Tool Can't Lookup Lombok Generated Stuff
Weltraumschaf Feb 16, 2024
f1cc201
#121 Extract Auth Header Facotry from Intermediate Class
Weltraumschaf Feb 16, 2024
8804bf1
#121 Extract Proxy Credential Facotry from Intermediate Class
Weltraumschaf Feb 16, 2024
814d455
#121 Log in Debug Level Which Auth Headers are Set
Weltraumschaf Feb 16, 2024
f5ff0ae
#121 Remove Unused field from Intermediate Class
Weltraumschaf Feb 16, 2024
7c192c0
#121 Give Config a Better Name to Make it More Distinguishable from P…
Weltraumschaf Feb 16, 2024
78f330a
#121 Log proxi configuration
Weltraumschaf Mar 1, 2024
29ba64d
#121 Do not Create Unecessary Objects
Weltraumschaf Mar 14, 2024
4f2ee00
#121 Use Better Variable Name
Weltraumschaf Mar 14, 2024
e5368d6
#121 Extract Method to Generate Base URL
Weltraumschaf Mar 14, 2024
f439576
#121 Mark Dedicated Constructor
Weltraumschaf Mar 14, 2024
e9ad077
#121 Make Vars Final
Weltraumschaf Mar 14, 2024
28c7c4b
#121 Add Bug Marker
Weltraumschaf Mar 15, 2024
eb975b1
#121 Add Missing JavaDoc
Weltraumschaf Mar 15, 2024
3309da3
#121 Use URI Instead of String
Weltraumschaf Mar 15, 2024
a537644
#121 Reformat Lambdas for Readability
Weltraumschaf Mar 15, 2024
1ce7c07
#121 Remove Obsolete Checked Exceptions from Method Signature
Weltraumschaf Mar 15, 2024
08f98cc
#121 Move Overloaded Method Before the Implemented
Weltraumschaf Mar 15, 2024
34abd4c
#121 Add Tests to Verify Presence of Auth Token in Headers
Weltraumschaf Mar 15, 2024
b67f8c5
#121 Hide Client Config Because Only USed in This Class
Weltraumschaf Mar 15, 2024
307747c
#121 Hide Rest Template Because Only USed in This Class
Weltraumschaf Mar 15, 2024
e00225a
#121 Extract Proxy Config As Field to Make it Injectable in Tests
Weltraumschaf Mar 15, 2024
9fb2b5e
#121 Give Method Better Name Since it is Not a Simple Getter
Weltraumschaf Mar 15, 2024
d72ee2f
#121 Add Tests to Verify Presence of Proxy Auth Header
Weltraumschaf Mar 15, 2024
9797207
#121 Remove Uneccessary Indirect Call to REST Template
Weltraumschaf Mar 15, 2024
190dfc7
#121 Reduce Coupling to Jackso by Extracting Mappers into Own Object
Weltraumschaf Mar 15, 2024
e4c7afd
#121 Remove Uneccessary This Qualifier
Weltraumschaf Mar 15, 2024
51c3122
#121 Give Class a More Meaningful Name
Weltraumschaf Mar 15, 2024
2d58c31
#121 Do Not Create Proxy Config Twice
Weltraumschaf Mar 15, 2024
4f67514
#121 Extract Request Entity Creation
Weltraumschaf Mar 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
#121 Do not Create Unecessary Objects
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Weltraumschaf committed Jul 3, 2024
commit 29ba64d720ba293c2915996ba8b2bf32a036de34
Original file line number Diff line number Diff line change
@@ -103,7 +103,7 @@ public final List<T> search(@NonNull Map<String, Object> queryParams) {

@Override
public final List<T> search() {
return search(new LinkedHashMap<>());
return search(Collections.emptyMap());
}

@Override